Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22758#discussion_r226151421
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -193,6 +193,16 @@ private[hive] class HiveMetastoreCatalog
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22758#discussion_r226150341
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -1051,7 +1051,8 @@ class StatisticsSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22745#discussion_r226149644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -509,3 +509,24 @@ case class UnresolvedOrdinal
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22309
what's still missing to support top level value class?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r226149168
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -632,13 +667,17 @@ object ScalaReflection extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r226148985
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -376,6 +386,23 @@ object ScalaReflection extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r226148892
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -376,6 +386,23 @@ object ScalaReflection extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226143221
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226142651
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -73,19 +73,21 @@ case class UserDefinedFunction
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226141983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +42,29 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22756#discussion_r226141315
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
@@ -125,8 +125,13 @@ class BisectingKMeansModel private[ml
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22721
what's the impact to end users? wrong statistics?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20999
It seems like Hive can drop partitions directly with a partition
expression:
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225952267
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +40,29 @@ import
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22732
After more thoughts, there is one case we don't handle well. For UDFs like
`(a: Any, i: Int) => xxx`, previously we can still get the int type info at
runtime, and add null check for it. Now
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22708
thanks, merging to master/2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22674
since there is no objection, I'm merging it to master, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22750
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22732
There is an argument about whether #22259 introduced behavior changes. Here
is my analysis.
Before #22259 , the type and null check was done as
1. user registers UDFs, like `(a: Int
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225807388
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -31,6 +31,9 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225804995
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21322
I'd like to recommend
http://apache-spark-developers-list.1001551.n3.nabble.com/SPIP-SPARK-25728-Structured-Intermediate-Representation-Tungsten-IR-for-generating-Java-code-td25370.html
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22746
This is very cool! thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r225797461
--- Diff: docs/_data/menu-sql.yaml ---
@@ -0,0 +1,79 @@
+- text: Getting Started
+ url: sql-getting-started.html
+ subitems:
+- text
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22724
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22708#discussion_r225767103
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanWithArraySuite.java ---
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22745
It's a different issue, I think it worth a new ticket
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225614430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -31,6 +31,7 @@ import
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22750
cc @gatorsmile @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22750
[SPARK-25747][SQL] remove ColumnarBatchScan.needsUnsafeRowConversion
## What changes were proposed in this pull request?
`needsUnsafeRowConversion` is used in 2 places:
1
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21322
I think a design doc is better, to make sure we are on the same page before
the actual coding, which saves time
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22708
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22708
cc @dongjoon-hyun here is another instance of the FileBasedDataSourceSuite
flaky test.
---
-
To unsubscribe, e-mail: reviews
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21322
Ah i see. It's kind of a broadcast but has a much small scope and its
lifecycle is bound to a stage. I'm looking forward to a full design of it,
thanks
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22724
yea +1 on 3.0 only, this is kind of a developer API, advanced users may use
it.
---
-
To unsubscribe, e-mail: reviews
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r225522164
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -31,48 +30,7 @@ import org.apache.spark.sql.types
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r225521786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedSafeProjection.scala
---
@@ -0,0 +1,173
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r225521397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedSafeProjection.scala
---
@@ -0,0 +1,173
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r225521206
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedSafeProjection.scala
---
@@ -0,0 +1,173
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r225520812
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedSafeProjection.scala
---
@@ -0,0 +1,173
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r225520290
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedSafeProjection.scala
---
@@ -0,0 +1,173
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22724
`Literal` is an internal API, and AFAIK end-users can't construct an
invalid `Literal` with public APIs. If they can, then it's a bug and we have a
problem
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22708
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22708
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22728
FYI, I tried both hive and presto, neither of them supports multi-column
count.
---
-
To unsubscribe, e-mail: reviews
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22597
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22724
LGTM pending jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22724#discussion_r225396907
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -196,6 +197,48 @@ object Literal {
case
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22379
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22724#discussion_r225392951
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -196,6 +197,48 @@ object Literal {
case
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22724#discussion_r225392843
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -196,6 +197,48 @@ object Literal {
case
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22724#discussion_r225392872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -196,6 +197,48 @@ object Literal {
case
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22597#discussion_r225373279
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
---
@@ -383,4 +385,17 @@ class OrcFilterSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22597#discussion_r225373223
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
---
@@ -383,4 +385,17 @@ class OrcFilterSuite
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22719
thanks, merging to 2.2!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22718
thanks, merging to 2.3!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22724#discussion_r225368754
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -196,6 +197,48 @@ object Literal {
case
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22731
LGTM, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22733
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22728
BTW MySQL doesn't support `count(a, b)` but supports `count(distinct a,
b)`, the result is same as Spark
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r225218562
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -777,7 +777,6 @@ case class SchemaOfJson
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22724#discussion_r225218350
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -196,6 +197,31 @@ object Literal {
case
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22728
cc @gatorsmile @mgaido91 @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22728
[SPARK-25736][SQL][TEST] add tests to verify the behavior of multi-column
count
## What changes were proposed in this pull request?
AFAIK multi-column count is not widely supported
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22379
have you addressed
https://github.com/apache/spark/pull/22379/files#r225033808 ?
---
-
To unsubscribe, e-mail: reviews
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r225183977
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -777,7 +777,6 @@ case class SchemaOfJson
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22708#discussion_r225182746
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
---
@@ -271,32 +272,41 @@ object JavaTypeInference
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22029
I don't have a strong opinion. cc @gatorsmile @hvanhovell @juliuszsompolski
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22029
So, the goal here is to make the behavior consistent between multi-column
IN-subquery and multi-column normal IN for Spark.
That said, I feel it's reasonable to change the behavior
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22724
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22029
> Oracle does the same.
So what's the behavior? return false?
> Hive behaves like Spark now (before and after the PR) for this case.
Again what's the behavior?
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20999
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22715
Hi @mgaido91 , since you are the major author of this part, do you have
time to open a PR and move `outputOrdering` to the main constructor? Thanks in
advance
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22713#discussion_r225119359
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -112,8 +112,8 @@ object EliminateView extends Rule
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22708#discussion_r225118613
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
---
@@ -271,32 +272,41 @@ object JavaTypeInference
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22561
Your rewrite is applied to the entire predicate expression tree, how about
the case `NOT(p AND x)`? If `p` is true, `x` is false, then `NOT(p AND x)` is
true. But `NOT(true AND true)` is false
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20999#discussion_r225108214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -523,35 +523,114 @@ case class AlterTableRenamePartitionCommand
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22029
Do you know how other databases behave for `(a, b) in (struct_col1,
struct_col2, ...)` and `input_struct_col in (struct_col1, struct_col2, ...)`?
Since `(a, b)` may be treated specially, we need
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22713#discussion_r225103000
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAliasAndProjectSuite.scala
---
@@ -124,4 +124,11 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r225079174
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala ---
@@ -34,11 +34,16 @@ import org.apache.spark.sql.types
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20999#discussion_r225074416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -293,6 +293,31 @@ class AstBuilder(conf: SQLConf
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20999#discussion_r225073862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -382,6 +382,30 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20999#discussion_r225074108
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -382,6 +382,30 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20999#discussion_r225076055
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -523,35 +523,114 @@ case class AlterTableRenamePartitionCommand
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22263
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21322
Introducing a new concept which is similar to broadcast seems like an
overkill. We can just update broadcast, to allow it to be memory-only.
However, there might be simpler solutions
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22561
Please describe the idea clearly in the PR description.
After reading the code, I think the idea is, for any predicate `p`, we can
rewrite it to `p'` that only contains partition columns
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22379
I wouldn't make schema a `Columm`. `Column` means it's dynamic, while I
think it should be a static value, to simplify the implementation
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22379
BTW how would the `schema_of_csv` function help with `from_csv`?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22379
Looks pretty good! just one minor commet
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r225033899
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala
---
@@ -254,7 +256,7 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r225033808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
---
@@ -0,0 +1,117 @@
+/*
+ * Licensed
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22029
It looks to me that this is another instance of special handling `(a, b,
..)`, like https://github.com/apache/spark/pull/21403
`(a, b) in (struct_col1, struct_col2, ...)` is different
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22708
Can you explain how this happens? Why thhe fields of structs get mixed up?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22561#discussion_r225030929
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala
---
@@ -39,21 +40,31 @@ private[sql] object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r225030497
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -125,6 +125,17 @@ object ScalaReflection extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r225030384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -376,6 +387,23 @@ object ScalaReflection extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r225030352
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -376,6 +387,23 @@ object ScalaReflection extends
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22697
thanks, merging to 2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22713#discussion_r225025827
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAliasAndProjectSuite.scala
---
@@ -124,4 +124,11 @@ class
901 - 1000 of 17635 matches
Mail list logo
