mparison succeeds when cxl create-region command emits nothing.
> Use the ! comparator when checking the create-region result.
>
> When checking the ram_size output of cxl-list add a check for empty.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Ira Weiny
Krzysztof Kozlowski wrote:
> virtio core already sets the .owner, so driver does not need to.
>
> Acked-by: Dave Jiang
Acked-by: Ira Weiny
> Signed-off-by: Krzysztof Kozlowski
> ---
>
> Depends on the first patch.
> ---
> drivers/nvdimm/virtio_pmem.c | 1 -
&g
Krzysztof Kozlowski wrote:
> virtio core already sets the .owner, so driver does not need to.
>
> Acked-by: Dave Jiang
Acked-by: Ira Weiny
> Signed-off-by: Krzysztof Kozlowski
> ---
>
> Depends on the first patch.
> ---
> drivers/nvdimm/virtio_pmem.c | 1 -
&g
here?
>
Ah... All great points.
Outside of CXL development I don't think there is a strong need for them
to be stable. I would like to see more than ad hoc scripts use them
though. So I don't think they are going to be changed without some
thought though.
Ira
[snip]
Shiyang Ruan wrote:
>
>
> 在 2024/4/24 5:04, Ira Weiny 写道:
> > Alison Schofield wrote:
> >> On Wed, Apr 17, 2024 at 03:50:52PM +0800, Shiyang Ruan wrote:
> >
> > [snip]
> >
> >>> diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core
mulation obsolete these commands?
I don't think so. In the development of the kernel, I see these being
valuable to do CI and regression testing without the complexity of an FM.
Ira
>
> > Note: we skips any FM issued extent release request if the exact extent
> > does not ex
gt; cxl_poison event be different.
>
> I prefer how poison defines it:
>
> cxlmem.h:#define CXL_POISON_START_MASK GENMASK_ULL(63, 6)
>
> Can we rename that CXL_EVENT_DPA_MASK and use for all events?
Ah! Great catch. I dont' know why I only masked off the 2 used bits.
That was short sighted of me.
Yes we should consolidate these.
Ira
ype == CXL_CPER_EVENT_DRAM)
> + cxl_event_handle_general_media(cxlmd, type, >gen_media);
> + } else if (event_type == CXL_CPER_EVENT_DRAM) {
> trace_cxl_dram(cxlmd, type, >dram);
> - else if (event_type == CXL_CPER_EVENT_MEM_MODULE)
> + cxl_event_handle_dra
Media Event Record")
> Cc:
> Cc: Dan Williams
> Cc: Davidlohr Bueso
> Cc: Jonathan Cameron
> Cc: Ira Weiny
Apologies I thought I saw this go in before. But perhaps it was a
different mask.
Reviewed-by: Ira Weiny
> Signed-off-by: Shiyang Ruan
> ---
> d
and a price.
Thanks,
Ira
Sent via mobile.Please excuse typos and autocorrects.
Visit the MoPo Mailing List Web Site at www.filmfan.com
___
How to UNSUBSCRIBE from the MoPo Mailing List
the meantime 1 was
> dropped, and 2 is still open(?). So there is more to work through now,
> then when it was dropped.
>
> If anyone wants to pick it up, it is fine by me. I can help with
> reviews.
I can help with reviews as well,
Ira
>
>
> [0] https://lwn.net/Articles/931406/
Good point and indeed doing it that way gives consistent sizes. I’ll let the
client developer know.
> On Mar 1, 2024, at 9:24 AM, Derek Atkins wrote:
>
> Hi,
>
> On Fri, March 1, 2024 9:21 am, Ira Fuchs wrote:
>> My MySQL client shows tables sizes.
>
> I would
My MySQL client shows tables sizes.
> On Mar 1, 2024, at 9:02 AM, Derek Atkins wrote:
>
> What queries are you running to compare the two databases?
>
> -derek
>
> On Fri, March 1, 2024 8:53 am, Ira Fuchs wrote:
>> They are precisely the same. No changes have
On Fri, March 1, 2024 8:30 am, Ira Fuchs wrote:
>> I have 2 instances of MySQL to which I save copies of my Gnucash data. I
>> have gnucash open with an xml file and I do a save to the first instance
>> and then I reopen the XML file and Save again, this time to another MySQL.
&
I have 2 instances of MySQL to which I save copies of my Gnucash data. I have
gnucash open with an xml file and I do a save to the first instance and then I
reopen the XML file and Save again, this time to another MySQL. In both cases
the save proceeds normally after warning the file will be
I am trying to save my Gbucash data to MySQl v8.0.36 on a newly installed MySQL
instance on WIndwos 10. Gnucash is running on a Mac and I also have a MySQL
instance on that machine running v .8.0.22. I have no problem saving the
gnucash data to the local MySQL instance but when I try to save it
Happy Birthday
I love this corner of the internet.
We should plan a party next year for 30!!!
Ira
Posterpalace.com
(Yes. After years of talking about it. I finally have started to sell some of
my collection and moon light in the poster dealer space. I have so much
A statement I posted on my Facebook page:
IMO:
Only the most hardened Biden Puppet will deny the obvious truth that Joe Biden
is mentally and physically deteriorating and should not be a candidate for
president. This is what happens when you're a puppet; you deny reality due to
your undying
Jonathan Cameron wrote:
> On Wed, 14 Feb 2024 17:33:18 -0500
> Steven Rostedt wrote:
>
> > On Wed, 14 Feb 2024 14:19:19 -0800
> > Ira Weiny wrote:
> >
> > > > > Jonathan Cameron wrote:
> > > > >
> > > >
Ira Weiny wrote:
> Jonathan Cameron wrote:
> > On Wed, 14 Feb 2024 10:23:10 -0500
> > Steven Rostedt wrote:
> >
> > > On Wed, 14 Feb 2024 12:11:53 +
> > > Jonathan Cameron wrote:
> > >
> > > > So I'm thinking this
gain thanks for the testing! However, Dan and I just discussed this and
he has an uneasy feeling about going forward with this for 6.8 final.
If we revert the following patch I can squash this fix and wait for the
tp_printk() fix to land in 6.9 and resubmit.
Dan here is the patch which backs out the actual bug:
Fixes: 671a794c33c6 ("acpi/ghes: Process CXL Component Events")
Thanks everyone,
Ira
t; lock debugging report that came up whilst testing it.
>
> For this patch (not a potential additional one that we aren't going to do ;)
>
> Tested-by: Jonathan Cameron
> Reviewed-by: Jonathan Cameron
Thanks Jonathan! I really appreciate the testing,
Ira
Ira Weiny wrote:
> Jonathan Cameron wrote:
> > On Tue, 06 Feb 2024 14:15:32 -0800
> > Ira Weiny wrote:
> >
> >
[snip]
> >
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 9ff8a439d674..7ee45f22f56f 100644
> > --- a/
Jonathan Cameron wrote:
> On Tue, 06 Feb 2024 14:15:32 -0800
> Ira Weiny wrote:
>
> > Smatch caught that cxl_cper_post_event() is called with a spinlock held
> > or preemption disabled.[1] The callback takes the device lock to
> > perform address translatio
Peter Robinson wrote:
> The ACPI_NFIT config option is described incorrectly as the
> inverse NFIT_ACPI, which doesn't exist, so update the help
> to the actual config option.
>
> Fixes: 18da2c9ee41a0 ("libnvdimm, pmem: move pmem to drivers/nvdimm/")
I don't think this warrants a fixes tag as
> even if the input to the macro is a smaller type, and so the shifts
> will be in range.
>
> Fixes: 845d80a8c7b187 ("qemu/bswap: Add const_le64()")
> Signed-off-by: Peter Maydell
Thanks!
Reviewed-by: Ira Weiny
While there, I estimated 25K-50K. After viewing aerial photos, I revised that
number to 100K max. Of course, these estimates are always difficult but 400K?
No way.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#28532):
Hi Linus, please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
tags/libnvdimm-for-6.8
... to get updates to the nvdimm tree. They are a mix of bug fixes and updates
to interfaces used by nvdimm.
Updates to interfaces include:
Use the new scope based
Randy Dunlap wrote:
>
>
> On 12/21/23 14:32, Ira Weiny wrote:
> > Randy Dunlap wrote:
> >
> > [snip]
> >
> >> @@ -1656,8 +1664,10 @@ static int select_pmem_id(struct nd_regi
> >> /**
> >> * create_namespace_pmem - validate interle
Ira Weiny wrote:
> Randy Dunlap wrote:
[snip]
> > diff -- a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
> > --- a/drivers/nvdimm/dimm_devs.c
> > +++ b/drivers/nvdimm/dimm_devs.c
> > @@ -53,7 +53,10 @@ static int validate_dimm(struct nvdimm_d
> >
&g
t; + * @nd_mapping: container of dpa-resource-root + labels
> * @nd_label: target pmem namespace label to evaluate
> + *
> + * Returns: the created device on success or -errno on error
NIT: should this be ERR_PTR(-errno) on error?
Generally good to me though.
Reviewed-by: Ira Weiny
>
found for return value of
> 'nvdimm_allocated_dpa'
>
> Signed-off-by: Randy Dunlap
> Cc: Dan Williams
> Cc: Vishal Verma
> Cc: Dave Jiang
> Cc: Ira Weiny
> Cc: nvd...@lists.linux.dev
> ---
> drivers/nvdimm/dimm_devs.c | 14 --
> 1 file changed, 12 inse
gt; Signed-off-by: Randy Dunlap
> Cc: Vishal Verma
> Cc: Dan Williams
> Cc: Dave Jiang
> Cc: Ira Weiny
Reviewed-by: Ira Weiny
> Cc: nvd...@lists.linux.dev
> ---
> drivers/nvdimm/btt.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
: Michal Wilczynski
> > > ---
> > >
> > > Dan, would you like me to give you credit for the changelog changes
> > > with Co-developed-by tag ?
> >
> > Nope, this looks good to me, thanks for fixing it up.
> >
> > Reviewed-by: Dan Williams
>
> Are you going to apply it too, or should I take it?
I'm prepping the nvdimm tree for 6.8. I will take it.
Ira
+1 to Tim - tell the reader explicitly that they will only ever get PQC w/
TLS 1.3 or higher.
Cheers,
- Ira
On Thu, Dec 21, 2023, 12:34 PM Tim Hollebeek wrote:
> I personally think this point is important enough to be made explicitly
> instead of implicitly.
>
>
>
> If we w
dinghao.liu@ wrote:
> > Ira Weiny wrote:
> > > Dinghao Liu wrote:
> >
> > [snip]
> >
> > -static int btt_freelist_init(struct arena_info *arena)
> > +static int btt_freelist_init(struct device *dev, struct arena_info *arena)
> >
> >
Ira Weiny wrote:
> Dinghao Liu wrote:
[snip]
> >
> > -static int btt_maplocks_init(struct arena_info *arena)
> > +static int btt_maplocks_init(struct device *dev, struct arena_info *arena)
> > {
> > u32 i;
> >
> > - arena->map_locks =
aths of create_arenas() and
discover_arenas(). In those cases devm_kfree() is probably a better way
to clean up this.
However...
> debugfs_remove_recursive(arena->debugfs_dir);
> kfree(arena);
Why can't arena be allocated with devm_*?
We need to change this up a bit more to handle the error path vs regular
device shutdown free (automatic devm frees).
Ira
prevent new ones from appearing.
>
> Link:
> http://lore.kernel.org/r/657897453dda8_269bd29...@dwillia2-mobl3.amr.corp.intel.com.notmuch
> Link:
> http://lore.kernel.org/r/6577b0c2a02df_a04c529...@dwillia2-xfh.jf.intel.com.notmuch
> Cc: Vishal Verma
> Cc: Ira Weiny
Reviewed-b
e, so change these
> where applicable.
>
> Cc: Joao Martins
> Suggested-by: Dan Williams
> Signed-off-by: Vishal Verma
>
Reviewed-by: Ira Weiny
d on driver detach, right?
On device put yes. So if these allocations are scoped to the life of the
device there would be no reason to call devm_kfree() on them at all. I was not
sure if they got reallocated at some point or not.
> 2. Using the scoped based management for struct btt_sb *super (not a bug,
>but it could improve the code).
Good!
>
> I'm not quite sure whether my understanding or bug fixing plan is correct.
> If there are any issues, please correct me, thanks!
The above sounds right.
Ira
not sure off the top of my head.
In addition, looking at this code. discover_arenas() could make use of
the scoped based management for struct btt_sb *super!
Dinghao would you be willing to submit a series of 2 or 3 patches to fix
the above issues?
Thanks!
Ira
p://lore.kernel.org/r/2023112729-aids-drainable-5744@gregkh
> Cc: Greg KH
> Cc: Yi Zhang
> Cc: Dave Jiang
> Cc: Ira Weiny
Reviewed-by: Ira Weiny
whenever a command fails.
>
> I do wonder if we need this new test - with Dave's patch here[1],
I'm not sure.
> destroy-region and disable-region both use the same helper that
> performs the libdaxctl checks.
>
> cxl-create-region.sh already has flows that create a region and then
> destroy it. Those should now cover this case as well yeah?
I thought it would have but I don't think it covers the case where the dax
device is not system ram (the default when creating a region).
Ira
Alison Schofield wrote:
> On Thu, Nov 30, 2023 at 08:06:13PM -0800, Ira Weiny wrote:
[snip]
> > +
> > +check_destroy_devdax()
> > +{
> > + mem=$1
> > + decoder=$2
> > +
> > + region=$($CXL create-region -d "$decoder" -m &q
emove unused memory_zone and mem_zone
>
> The enum memory_zone definition and mem_zone variable have never been used so
> remove them.
NIT: I don't know that they have never been used but they certainly seem
to have been moved to the library.
>
> Signed-off-by: Xiao Yang
Reviewed-by: Ira Weiny
as is the case for a region with only devdax devices. Such
devices do not need to be off-lined explicitly.
Skip non-system-ram devices rather than error the operation.
Fixes: 9399aa667ab0 ("cxl/region: Add -f option for disable-region")
Cc: Dave Jiang
Signed-off-by: Ira Weiny
---
cx
Commit 9399aa667ab0 ("cxl/region: Add -f option for disable-region")
introduced a regression when destroying a region.
Add a tests for destroying a region.
Cc: Dave Jiang
Signed-off-by: Ira Weiny
---
test/cxl-destroy-region.sh | 76 ++
The patch to force device tear down on region disable caused a
regression for regions without system ram.
Add a test for such a case and a fix to the patch.
Signed-off-by: Ira Weiny
---
[djiang: RESEND with proper mailing lists.]
---
Ira Weiny (2):
ndctl/test: Add destroy region test
Hi,
Approve.
Cheers,
- Ira
On Wed, Nov 29, 2023 at 10:51 AM Joseph Salowey wrote:
> RFC 8773 (TLS 1.3 Extension for Certificate-Based Authentication with an
> External Pre-Shared Key) was originally published as experimental due to
> lack of implementations. As part of implementa
Greg KH wrote:
> On Mon, Nov 27, 2023 at 10:00:14AM -0700, Dave Jiang wrote:
> >
> >
[snip]
> Ick, sorry about that, obviously this test isn't actually built by any
> bots :(
Indeed. I'm looking through the tests I ran now.
>
> I'll go queue this up now,
Thanks,
Ira
-mem2,num-dc-regions=2,nonvolatile-dc-memdev=cxl-dc-mem2,id=cxl-dev2,lsa=cxl-lsa2,sn=2
-device
cxl-type3,bus=hb1rp1,memdev=cxl-mem3,num-dc-regions=2,nonvolatile-dc-memdev=cxl-dc-mem3,id=cxl-dev3,lsa=cxl-lsa3,sn=3
...
Ira
[1]
https://lore.kernel.org/all/20231116-fix-cdat-devm-free-v1-1-b148b4070.
Hi Linus, please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
tags/libnvdimm-for-6.7
... to get updates to the nvdimm tree. They are a mix of bug fixes and updates
to interfaces used by nvdimm.
Bug fixes include:
Fix a sleep during spinlock in
>
> And the fix is correct if I'm not mistaken.
>
> I can still queue it up for 6.6 if that's fine with everyone. Dan?
That is fine with me. Vishal, Dave Jiang, and I are wrangling the nvdimm
tree these days. I've prepared 6.7 already so I'll ignore this.
Ira
>
> &g
Dan Williams
> Cc: Vishal Verma
> Cc: Dave Jiang
> Cc: Ira Weiny
Tested-by: Ira Weiny
Reviewed-by: Ira Weiny
> Signed-off-by: Greg Kroah-Hartman
> ---
> tools/testing/nvdimm/test/ndtest.c | 17 +
> tools/testing/nvdimm/test/nfit.c | 14 +++---
&
When creating a region if the size exceeds the max an error is printed.
However, the max available space is not reported which makes it harder
to determine what is wrong.
Add the max size available to the output error.
Signed-off-by: Ira Weiny
---
cxl/region.c | 4 ++--
1 file changed, 2
CXL event testing is only appropriate when the cxl-test modules are
available.
Return error 77 (skip) if cxl-test modules are not available.
Reported-by: Dave Jiang
Signed-off-by: Ira Weiny
---
Changes for resend:
- iweiny: properly cc the mailing lists
---
test/cxl-events.sh | 3 +++
1 file
> Fixes: 5212e11fde4d ("nd_btt: atomic sector updates")
> Signed-off-by: Tomas Glozar
Thanks for the clarification.
Reviewed-by: Ira Weiny
Tomas Glozar wrote:
> čt 14. 9. 2023 v 22:18 odesílatel Ira Weiny napsal:
> > Is the bug in 1 of 2 places?
> >
> > 1) When btt_write_pg()->lock_map() (when the number of lanes is < number
> >of cpus) and the lane is acquired is called?
> >
> >
ave let more gpl-2-only code into the
> > codebase without a rationale...)
I'm curious about this statement. Does the qemu project not want gpl v2
only code? I agree with Jonathan that this is the intention of Ben's
initial submission; so from that PoV.
Acked-by: Ira Weiny
Going forwar
Chen Ni wrote:
> Use devm_kstrdup() instead of kstrdup() and check its return value to
> avoid memory leak.
>
> Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus
> provider")
> Signed-off-by: Chen Ni
Reviewed-by: Ira Weiny
> ---
> Cha
Yu Liao wrote:
> Make use of the struct_size() helper instead of an open-coded version,
> in order to avoid any potential type mistakes or integer overflows that,
> in the worst scenario, could lead to heap overflows.
>
> Signed-off-by: Yu Liao
> Reviewed-by: Dave Jiang
Revi
ddDVKsqQX@kreacher/
>
> Fixes: 2a5ab99847bd ("ACPICA: struct acpi_nfit_interleave: Replace 1-element
> array with flexible array")
> Cc: sta...@vger.kernel.org # v6.4+
> Signed-off-by: Yu Liao
> Reviewed-by: Dave Jiang
Reviewed-by: Ira Weiny
> ---
> v1 ->
been more clear I think.
Regardless I *think* this is ok but I'm worried I don't fully understand
what the problem is.
Ira
>
> Fix the issue by replacing get_cpu with smp_process_id and
> migrate_disable when needed. This makes BTT operations preemptible, thus
> permitting the use of
urce management burden.
I think it could be but this is the driver and I wonder if leaving the
allocation around until the platform device goes away was undesirable for
some reason?
Ira
r(>dev, >bus_desc);
> if (!bus) {
> + kfree(priv->bus_desc.provider_name);
If not using devm_kstrdup() don't you need a kfree in
of_pmem_region_remove?
Ira
> kfree(priv);
> return -ENODEV;
> }
> --
> 2.25.1
>
Verma, Vishal L wrote:
> On Mon, 2023-07-31 at 16:53 -0700, Ira Weiny wrote:
> > Previously CXL event testing was run by hand. This reduces testing
>
> Reduces or increases / improves? Or did you mean running by hand
> reduced coverage.
Running by hand reduces test cov
are not checked.
Signed-off-by: Ira Weiny
---
Changes in v2:
[djiang] run shellcheck and fix as needed
[vishal] quote variables
[vishal
Verma, Vishal L wrote:
> On Thu, 2023-07-27 at 14:21 -0700, Ira Weiny wrote:
> > Previously CXL event testing was run by hand. This reduces testing
> > coverage including a lack of regression testing.
> >
> > Add a CXL test as part of the meson test infrastructure.
I don't see
> any reason to to more repairs right now.
> Thank you for the support :)
Oh, shipping to California and back is probably not reasonable.
-- Ira
--
You received this message because you are subscribed to the Google Groups
"Brewtus" group.
To unsubscribe from this gro
Dave Jiang wrote:
>
>
> On 7/27/23 14:21, Ira Weiny wrote:
> > Previously CXL event testing was run by hand. This reduces testing
> > coverage including a lack of regression testing.
> >
> > Add a CXL test as part of the meson test infrastructure. Passi
.
Signed-off-by: Ira Weiny
---
test/cxl-events.sh | 68 ++
test/meson.build | 2 ++
2 files changed, 70 insertions(+)
diff --git a/test/cxl-events.sh b/test/cxl-events.sh
new file mode 100644
index ..f51046ec39ad
--- /dev/null
hat I can see. But might be nice to check or just use my fix.
I'll try and get to a review once I get the DCD stuff out on the list again.
Ira
[2]
../hw/mem/cxl_type3.c: In function
‘qmp_cxl_process_dynamic_capacity_event.constprop’:
../hw/mem/cxl_type3.c:2063:28: error: ‘rid’ may be used uninitia
ion.
>
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com/
> [2]: https://lwn.net/Articles/836503/
>
> Suggested-by: Ira Weiny
Reviewed-by: Ira Weiny
> Signed-off-by: Sumitra Sharma
> ---
> drivers/gpu/drm/gma500/mmu.c | 11 +++
> 1 file c
Add read/write support from/to DC regions of the device.
> 6. Add mechanism to validate accessed to DC region address space.
>
Sorry I see them in this other thread now.
https://lore.kernel.org/all/sg2pr06mb3397f3e74a083607f7492fa4b2...@sg2pr06mb3397.apcprd06.prod.outlook.com/
Thanks,
Ira
>
nifan@ wrote:
> From: Fan Ni
>
> The patch series provides dynamic capacity device (DCD) emulation in Qemu.
I don't the patches on the list.
https://lore.kernel.org/all/sg2pr06mb33976bb3f9c47cbe08f02d09b2...@sg2pr06mb3397.apcprd06.prod.outlook.com/
Did they get sent?
Ira
> More
;)
> Signed-off-by: Jiasheng Jiang
LTGM
Reviewed-by: Ira Weiny
> ---
> Changelog:
>
> v2 -> v3:
>
> 1. Correct the usage of devm_kstrdup().
>
> v1 -> v2:
>
> 1. Replace kstrdup() with devm_kstrdup().
> ---
> drivers/nvdimm/of_pmem.c | 7 ++-
&g
work
he is doing.
Anyone know of Galleries I can visit in Kentucky? Next stop as we visit the
bourbon trail.
Ira
Sent via mobile.Please excuse typos and autocorrects.
Visit the MoPo Mailing List Web Site at www.filmfan.com
I just upgraded to v5.2 and I can no longer save changes. I get this error:
Could not write to file /Users/if/Documents/GnuCash folder/
gnucash_transactions.gnucash.20181105195638.gnucash.
20211205203910.gnucash. Check that you have permission to write to this file
and that there is sufficient
Jiasheng Jiang wrote:
> On Wed, Jun 21, 2023 at 00:04:36 +0800, Ira Weiny wrote:
> > Ira Weiny wrote:
> >> Jiasheng Jiang wrote:
[snip]
> >>
> >> Nice catch!
> >>
> >> However, this free needs to happen in of_pmem_region_remove() as wel
ULL on failure.
*/
char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp)
^^
??
Ira
> + if (!priv->bus_desc.provider_name) {
> + kfree(priv);
> + return -ENOMEM;
> + }
> +
> priv->bus_desc.module = THIS_MODULE;
> priv->bus_desc.of_node = np;
>
> --
> 2.25.1
>
Jam with Bugs and Jordan. Anyone have any they would sell
me?
Please be kind to my store. I have lots and lots to learn. Lots more posters
to list. Of course any constructive feedback is always appreciated.
Thanks,
Ira
Visit the MoPo Mailing List Web Site at www.filmfan.com
re is just no other
way around supporting them.
Also Sumitra, and our kmap conversion project in general, is focusing on
not using kmap* if at all possible. Thus the reason V1 tried to use
page_address().
Could we guarantee the i915 driver is excluded from all HIGHMEM systems?
>
> With that said, my Reviewed-by: still stands.
Thanks!
Ira
re is just no other
way around supporting them.
Also Sumitra, and our kmap conversion project in general, is focusing on
not using kmap* if at all possible. Thus the reason V1 tried to use
page_address().
Could we guarantee the i915 driver is excluded from all HIGHMEM systems?
>
> With that said, my Reviewed-by: still stands.
Thanks!
Ira
Ira Weiny wrote:
> Jiasheng Jiang wrote:
> > Add check for the return value of kstrdup() and return the error
> > if it fails in order to avoid NULL pointer dereference.
> > Moreover, use kfree() in the later error handling in order to avoid
> > memory leak.
&
t;bus_desc);
> if (!bus) {
> + kfree(priv->bus_desc.provider_name);
Nice catch!
However, this free needs to happen in of_pmem_region_remove() as well.
Ira
> kfree(priv);
> return -ENODEV;
> }
> --
> 2.25.1
>
Sumitra Sharma wrote:
> On Sun, Jun 18, 2023 at 11:11:08AM -0700, Ira Weiny wrote:
> > Sumitra Sharma wrote:
> > > kmap() has been deprecated in favor of the kmap_local_page()
> > > due to high cost, restricted mapping space, the overhead of a
> > > global
Sumitra Sharma wrote:
> On Sun, Jun 18, 2023 at 11:11:08AM -0700, Ira Weiny wrote:
> > Sumitra Sharma wrote:
> > > kmap() has been deprecated in favor of the kmap_local_page()
> > > due to high cost, restricted mapping space, the overhead of a
> > > global
Yes but the monoplex needs to communicate over CTCs to the SYSPLEX.
Sent from my iPhone
> On Jun 19, 2023, at 10:25 AM, Paul Gorlinsky wrote:
>
> We have a sandbox system that references TSO user and ISV catalogs and
> datasets. The sandbox has a unique master catalog but shares virtually
ction
> “i915_vma_coredump_create” in i915_gpu_error.c
>
> Therefore, replace kmap() with kmap_local_page().
>
> Suggested-by: Ira Weiny
>
NIT: No need for the line break between Suggested-by and your signed off line.
> Signed-off-by: Sumitra Sharma
> ---
>
&g
ction
> “i915_vma_coredump_create” in i915_gpu_error.c
>
> Therefore, replace kmap() with kmap_local_page().
>
> Suggested-by: Ira Weiny
>
NIT: No need for the line break between Suggested-by and your signed off line.
> Signed-off-by: Sumitra Sharma
> ---
>
&g
Dan Williams wrote:
> Ira Weiny wrote:
> > Dan Williams wrote:
> > > The reference counting of dax_region objects is needlessly complicated,
> > > has lead to confusion [1], and has hidden a bug [2]. Towards cleaning up
> > > that mess introduce alloc_
static?
A different version of this fix has already been queued up.
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/commit/?h=libnvdimm-fixes=2d5153526f929838b0912ded26862840f72745f4
Thank you anyway,
Ira
Ben Dooks wrote:
> The nd_class is not used outside of drivers/nvdimm/bus.c and thus sparse
> is generating the following warning. Remove this by making it static:
>
> drivers/nvdimm/bus.c:28:14: warning: symbol 'nd_class' was not declared.
> Should it be static?
Reviewe
Better get all your shipping done before July 31 if you use UPS….
https://www.washingtonpost.com/business/2023/06/15/ups-strike-vote-teamsters/
Thousands of Teamster UPS drivers across the United States are expected to
authorize a strike Friday, bringing the country a step closer to what would
ni...@outlook.com wrote:
> The 06/08/2023 08:43, Ira Weiny wrote:
> > Shesha Bhushan Sreenivasamurthy wrote:
[snip]
>
> Hi Ira & Shesha,
> FYI. I reabased my patch series on top of the above branch and created a new
> branch here:
>
> https://github.com/moking/q
23/qemu/-/tree/cxl-2023-05-25
This is the branch I'm trying to use as well.
Thanks,
Ira
Fan Ni wrote:
> The 06/02/2023 23:14, Dan Williams wrote:
> > Now that free_dev_dax_id() internally manages the references it needs
> > the extra references taken by the dax_region drivers are not needed.
> >
> > Reported-by: Ira Weiny
> > Signed-off-by: Dan W
h series may need to be
> updated
> accordingly if the kernel side implementation changes.
Fan,
Do you have a git tree we can pull this from which is updated to a more
recent CXL branch from Jonathan?
Thanks,
Ira
>
> To support DCD emulation, the patch series add DCD related mailbo
Dan Williams wrote:
> Now that free_dev_dax_id() internally manages the references it needs
> the extra references taken by the dax_region drivers are not needed.
>
> Reported-by: Ira Weiny
Reviewed-by: Ira Weiny
> Signed-off-by: Dan Williams
> ---
> drivers/d
1 - 100 of 13056 matches
Mail list logo
