[kudu-CR] [ntp] improve two arithmetic operator

2021-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/17852 ) Change subject: [ntp] improve two arithmetic operator .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 6: I seem to recall that adar had a simpler

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15802 ) Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .. KUDU-2844 (3/3): avoid copying

[kudu-CR] WIP: support keys not at the front of a schema

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15748 ) Change subject: WIP: support keys not at the front of a schema .. Patch Set 2: I think this needs some more fixup to have better test

[kudu-CR] WIP: support keys not at the front of a schema

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15748 ) Change subject: WIP: support keys not at the front of a schema .. WIP: support keys not at the front of a schema Change-Id:

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Add .clang-format file This clang-format file seems to capture our existing style

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Patch Set 2: Verified+1 Not waiting for Jenkins since there's no code change here. -- To

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16260 to look at the new patch set (#2). Change subject: Add .clang-format file

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/16260/1/docs/contributing.adoc

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-25 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15802 to look at the new patch set (#7). Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. KUDU-2844 (2/3): move RowBlock memory

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. KUDU-2844 (1/3): make BlockHandle ref-counted This is the

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15800 to look at the new patch set (#4). Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-13 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15802 to look at the new patch set (#6). Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-13 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15802 to look at the new patch set (#5). Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15800 to look at the new patch set (#3). Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-13 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15801 to look at the new patch set (#5). Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: (1 comment)

[kudu-CR] WIP KUDU-1587 part 1: load meter for ThreadPool

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16332 ) Change subject: WIP KUDU-1587 part 1: load meter for ThreadPool .. Patch Set 1: just did a quick skim over the patch, would be good to

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-12 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15802 to look at the new patch set (#4). Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-12 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15800 to look at the new patch set (#2). Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-12 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15801 to look at the new patch set (#4). Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15802 ) Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 1: (5 comments)

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 3: (6 comments)

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16137 to look at the new patch set (#12). Change subject: Optimize GetTableLocations for better arena use

[kudu-CR] Remove last vestiges of gscoped ptr

2020-07-30 Thread Todd Lipcon (Code Review)
Hello Adar Lieber-Dembo, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16261 to review the following change. Change subject: Remove last vestiges of gscoped_ptr .. Remove

[kudu-CR] Add .clang-format file

2020-07-30 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16260 to review the following change. Change subject: Add .clang-format file .. Add .clang-format file

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16137 to look at the new patch set (#11). Change subject: Optimize GetTableLocations for better arena use

[kudu-CR] rpc: Change InboundCall arena to 4kB by default

2020-07-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16249 ) Change subject: rpc: Change InboundCall arena to 4kB by default .. rpc: Change InboundCall arena to 4kB by default This changes

[kudu-CR] rpc: Change InboundCall arena to 4kB by default

2020-07-29 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16249 to look at the new patch set (#2). Change subject: rpc: Change InboundCall arena to 4kB by default

[kudu-CR] master-test: reuse protobuf for response

2020-07-29 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16255 to review the following change. Change subject: master-test: reuse protobuf for response .. master-test: reuse

[kudu-CR] rpc: Change InboundCall arena to 4kB by default

2020-07-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16249 ) Change subject: rpc: Change InboundCall arena to 4kB by default .. Patch Set 1: (2 comments)

[kudu-CR] rpc: Change InboundCall arena to 4kB by default

2020-07-28 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16249 to review the following change. Change subject: rpc: Change InboundCall arena to 4kB by default .. rpc: Change

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-28 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16137 to look at the new patch set (#9). Change subject: Optimize GetTableLocations for better arena use

[kudu-CR] table locations-itest: reuse protobufs in the benchmark client

2020-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16236 ) Change subject: table_locations-itest: reuse protobufs in the benchmark client .. table_locations-itest: reuse protobufs in the

[kudu-CR] table locations-itest: reuse protobufs in the benchmark client

2020-07-24 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16236 to review the following change. Change subject: table_locations-itest: reuse protobufs in the benchmark client ..

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16209 ) Change subject: tls_socket: avoid cork/uncork dance for small writevs .. tls_socket: avoid cork/uncork dance for small writevs

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-23 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16209 to look at the new patch set (#2). Change subject: tls_socket: avoid cork/uncork dance for small writevs

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16209 ) Change subject: tls_socket: avoid cork/uncork dance for small writevs .. Patch Set 1: (5 comments)

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-16 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16209 to review the following change. Change subject: tls_socket: avoid cork/uncork dance for small writevs ..

[kudu-CR] loadgen: use multiple KuduClient instances

2020-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16184 ) Change subject: loadgen: use multiple KuduClient instances .. loadgen: use multiple KuduClient instances KuduClient is

[kudu-CR] tablet: acquire/release locks in batches

2020-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. Patch Set 5: (1 comment)

[kudu-CR] tablet: acquire/release locks in batches

2020-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. tablet: acquire/release locks in batches Prior to this patch, each

[kudu-CR] tablet: acquire/release locks in batches

2020-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: tablet: acquire/release locks in batches .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16169 To unsubscribe, visit

[kudu-CR] tablet: acquire/release locks in batches

2020-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. Patch Set 5: Verified+1 Failure looks unrelated. This should be ready for a

[kudu-CR] tablet: acquire/release locks in batches

2020-07-14 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16169 to look at the new patch set (#5). Change subject: tablet: acquire/release locks in batches

[kudu-CR] tablet: acquire/release locks in batches

2020-07-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. Patch Set 2: (12 comments)

[kudu-CR] tablet: acquire/release locks in batches

2020-07-14 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16169 to look at the new patch set (#4). Change subject: tablet: acquire/release locks in batches

[kudu-CR] client: allocate InFlightOp from a Batcher Arena

2020-07-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16189 ) Change subject: client: allocate InFlightOp from a Batcher Arena .. client: allocate InFlightOp from a Batcher Arena

[kudu-CR] tablet: acquire/release locks in batches

2020-07-13 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16169 to look at the new patch set (#3). Change subject: tablet: acquire/release locks in batches

[kudu-CR] client: allocate InFlightOp from a Batcher Arena

2020-07-13 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16189 to look at the new patch set (#2). Change subject: client: allocate InFlightOp from a Batcher Arena

[kudu-CR] client: allocate InFlightOp from a Batcher Arena

2020-07-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16189 ) Change subject: client: allocate InFlightOp from a Batcher Arena .. Patch Set 1: (1 comment)

[kudu-CR] client: allocate InFlightOp from a Batcher Arena

2020-07-13 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16189 to review the following change. Change subject: client: allocate InFlightOp from a Batcher Arena ..

[kudu-CR] WIP: tablet: acquire/release locks in batches

2020-07-13 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16169 to look at the new patch set (#2). Change subject: WIP: tablet: acquire/release locks in batches

[kudu-CR] loadgen: use multiple KuduClient instances

2020-07-13 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16184 to review the following change. Change subject: loadgen: use multiple KuduClient instances .. loadgen: use

[kudu-CR] WIP: lock manager batch release

2020-07-10 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16169 to review the following change. Change subject: WIP: lock manager batch release .. WIP: lock manager batch release

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16162 ) Change subject: KUDU-636. Use Arena for EncodedKeys .. Patch Set 4: Verified+1 Test failure looks unrelated -- To view, visit

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-636. Use Arena for EncodedKeys .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16162 To unsubscribe, visit

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16162 ) Change subject: KUDU-636. Use Arena for EncodedKeys .. KUDU-636. Use Arena for EncodedKeys This updates EncodedKeyBuilder,

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16162 to look at the new patch set (#4). Change subject: KUDU-636. Use Arena for EncodedKeys ..

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16162 ) Change subject: KUDU-636. Use Arena for EncodedKeys .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16162 to look at the new patch set (#3). Change subject: KUDU-636. Use Arena for EncodedKeys ..

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16162 to look at the new patch set (#2). Change subject: KUDU-636. Use Arena for EncodedKeys ..

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-09 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16162 to review the following change. Change subject: KUDU-636. Use Arena for EncodedKeys .. KUDU-636. Use Arena for

[kudu-CR] KUDU-636. Use protobuf arenas for CommitMsgs

2020-07-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16147 ) Change subject: KUDU-636. Use protobuf arenas for CommitMsgs .. Patch Set 3: also worth noting I rebased this away from the

[kudu-CR] KUDU-636. Use protobuf arenas for CommitMsgs

2020-07-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16147 ) Change subject: KUDU-636. Use protobuf arenas for CommitMsgs .. Patch Set 3: (2 comments) think I fixed the issues but we'll see what

[kudu-CR] KUDU-636. Use protobuf arenas for CommitMsgs

2020-07-09 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16147 to look at the new patch set (#3). Change subject: KUDU-636. Use protobuf arenas for CommitMsgs

[kudu-CR] Enable arenas for RPC request and response

2020-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16136 ) Change subject: Enable arenas for RPC request and response .. Enable arenas for RPC request and response This changes the RPC

[kudu-CR] Enable arenas for RPC request and response

2020-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Enable arenas for RPC request and response .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16136 To unsubscribe, visit

[kudu-CR] Enable arenas for RPC request and response

2020-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16136 ) Change subject: Enable arenas for RPC request and response .. Patch Set 5: Verified+1 The failure here is a pre-existing LSAN issue

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Upgrade C++ to protobuf 3.12 This has various performance improvements, and

[kudu-CR] Use protobuf arenas for CommitMsgs

2020-07-07 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16147 to look at the new patch set (#2). Change subject: Use protobuf arenas for CommitMsgs .. Use

[kudu-CR] Enable arenas for RPC request and response

2020-07-07 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16136 to look at the new patch set (#5). Change subject: Enable arenas for RPC request and response

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16135 to look at the new patch set (#5). Change subject: Upgrade C++ to protobuf 3.12

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-07 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16137 to look at the new patch set (#7). Change subject: Optimize GetTableLocations for better arena use

[kudu-CR] Enable arenas for RPC request and response

2020-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16136 ) Change subject: Enable arenas for RPC request and response .. Patch Set 4: (7 comments)

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Patch Set 4: (13 comments)

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-06 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16135 to look at the new patch set (#4). Change subject: Upgrade C++ to protobuf 3.12

[kudu-CR] Use protobuf arenas for CommitMsgs

2020-07-06 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16147 to review the following change. Change subject: Use protobuf arenas for CommitMsgs .. Use protobuf arenas for

[kudu-CR] Enable arenas for RPC request and response

2020-07-06 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16136 to look at the new patch set (#4). Change subject: Enable arenas for RPC request and response

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Patch Set 3: (1 comment)

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-02 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16135 to look at the new patch set (#3). Change subject: Upgrade C++ to protobuf 3.12 ..

[kudu-CR] WIP: Enable arenas for RPC request and response

2020-07-02 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16136 to look at the new patch set (#3). Change subject: WIP: Enable arenas for RPC request and response

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-02 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16137 to look at the new patch set (#4). Change subject: Optimize GetTableLocations for better arena use

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-02 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16137 to look at the new patch set (#3). Change subject: Optimize GetTableLocations for better arena use

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-02 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16135 to look at the new patch set (#2). Change subject: Upgrade C++ to protobuf 3.12 ..

[kudu-CR] WIP: Enable arenas for RPC request and response

2020-07-02 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16136 to look at the new patch set (#2). Change subject: WIP: Enable arenas for RPC request and response

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-01 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16137 to review the following change. Change subject: Optimize GetTableLocations for better arena use .. Optimize

[kudu-CR] Enable arenas for RPC request and response

2020-07-01 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16136 to review the following change. Change subject: Enable arenas for RPC request and response .. Enable arenas for

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-01 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16135 to review the following change. Change subject: Upgrade C++ to protobuf 3.12 .. Upgrade C++ to protobuf 3.12 This

[kudu-CR] [master] cache for table locations

2020-06-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15971 ) Change subject: [master] cache for table locations .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15971/3//COMMIT_MSG

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. Patch Set 1: Why not just recommend devtoolset-6 or

[kudu-CR] [tests] add same tablet concurrent writes test

2020-06-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16060 ) Change subject: [tests] add same_tablet_concurrent_writes test .. Patch Set 2: (1 comment)

[kudu-CR] [util] clean up on BlockingQueue

2020-06-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16063 ) Change subject: [util] clean up on BlockingQueue .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16063/1//COMMIT_MSG

[kudu-CR] [util] clean up on BlockingQueue

2020-06-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16063 ) Change subject: [util] clean up on BlockingQueue .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16063/1//COMMIT_MSG

  1   2   3   4   5   6   7   8   9   10   >