[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986642#comment-13986642
]
Michael Shuler commented on CASSANDRA-6694:
---
Comparing the default 2.1 dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984175#comment-13984175
]
Benedict commented on CASSANDRA-6694:
-
I've pushed another slightly tweaked
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984208#comment-13984208
]
Benedict commented on CASSANDRA-6694:
-
Pushed one last change, based on comments
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983417#comment-13983417
]
Benedict commented on CASSANDRA-6694:
-
I've pushed a completed branch
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983425#comment-13983425
]
Benedict commented on CASSANDRA-6694:
-
Oh, also, [~iamaleksey]: Your assertion
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983666#comment-13983666
]
Aleksey Yeschenko commented on CASSANDRA-6694:
--
bq. This was a conscious
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983670#comment-13983670
]
Benedict commented on CASSANDRA-6694:
-
I don't mind dropping it, but it seems a
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983675#comment-13983675
]
Aleksey Yeschenko commented on CASSANDRA-6694:
--
Sure, but I prefer to add
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983708#comment-13983708
]
Benedict commented on CASSANDRA-6694:
-
To make shipping easier, I've pushed a
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983709#comment-13983709
]
Pavel Yaskevich commented on CASSANDRA-6694:
Here is a [new
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980847#comment-13980847
]
Benedict commented on CASSANDRA-6694:
-
On the whole it looks good, but I have the
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981434#comment-13981434
]
Pavel Yaskevich commented on CASSANDRA-6694:
1-2, 5-7 I will address once
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980585#comment-13980585
]
Pavel Yaskevich commented on CASSANDRA-6694:
I have pushed allocation
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1394#comment-1394
]
Aleksey Yeschenko commented on CASSANDRA-6694:
--
h3. Benedict’s original
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975540#comment-13975540
]
Benedict commented on CASSANDRA-6694:
-
[~iamaleksey] have you had a chance to take
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975677#comment-13975677
]
Aleksey Yeschenko commented on CASSANDRA-6694:
--
[~benedict] It's on the
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972524#comment-13972524
]
Benedict commented on CASSANDRA-6694:
-
So, on the whole I really don't perceive
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972776#comment-13972776
]
Pavel Yaskevich commented on CASSANDRA-6694:
To address all of your
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972796#comment-13972796
]
Benedict commented on CASSANDRA-6694:
-
bq. the scope is introduce native
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972832#comment-13972832
]
Marcus Eriksson commented on CASSANDRA-6694:
I'm +1 on [~benedict]s branch
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973220#comment-13973220
]
Pavel Yaskevich commented on CASSANDRA-6694:
bq. Well, these are still
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973226#comment-13973226
]
Benedict commented on CASSANDRA-6694:
-
bq. CounterCell.diff and reconcile are
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973297#comment-13973297
]
Pavel Yaskevich commented on CASSANDRA-6694:
I'm not talking about default
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973395#comment-13973395
]
Aleksey Yeschenko commented on CASSANDRA-6694:
--
bq. It's purpose is
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973405#comment-13973405
]
Benedict commented on CASSANDRA-6694:
-
bq. Can you make my OCD a tiny favor and
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973435#comment-13973435
]
Pavel Yaskevich commented on CASSANDRA-6694:
Regarding, the hashCode
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973534#comment-13973534
]
Pavel Yaskevich commented on CASSANDRA-6694:
Ok, hashCode and setPeer
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973538#comment-13973538
]
Benedict commented on CASSANDRA-6694:
-
I don't think this is the right approach:
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973571#comment-13973571
]
Pavel Yaskevich commented on CASSANDRA-6694:
I just don't like that in
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973582#comment-13973582
]
Benedict commented on CASSANDRA-6694:
-
The only reason it was happening in
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973595#comment-13973595
]
Pavel Yaskevich commented on CASSANDRA-6694:
Sure, if you like that better
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973618#comment-13973618
]
Pavel Yaskevich commented on CASSANDRA-6694:
Done, I have force pushed to
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973633#comment-13973633
]
Benedict commented on CASSANDRA-6694:
-
Thanks. Although it looks like you haven't
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973645#comment-13973645
]
Pavel Yaskevich commented on CASSANDRA-6694:
Why it does - internalPeer
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973647#comment-13973647
]
Benedict commented on CASSANDRA-6694:
-
bq. This still intended as just an idea
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970487#comment-13970487
]
Pavel Yaskevich commented on CASSANDRA-6694:
Also it seems like for some
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970603#comment-13970603
]
Benedict commented on CASSANDRA-6694:
-
bq. for now we are allocating
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972205#comment-13972205
]
Pavel Yaskevich commented on CASSANDRA-6694:
So here is the
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970462#comment-13970462
]
Pavel Yaskevich commented on CASSANDRA-6694:
[~benedict] While working on
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965066#comment-13965066
]
Pavel Yaskevich commented on CASSANDRA-6694:
[~jbellis] I will leave this
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965465#comment-13965465
]
Jonathan Ellis commented on CASSANDRA-6694:
---
bq. why we can't have a simple
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965481#comment-13965481
]
Jonathan Ellis commented on CASSANDRA-6694:
---
bq. Can we decide if we
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965487#comment-13965487
]
Jonathan Ellis commented on CASSANDRA-6694:
---
bq. Is it essential to move
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965493#comment-13965493
]
Benedict commented on CASSANDRA-6694:
-
I agree data is a bit meaningless - and, in
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965502#comment-13965502
]
Jonathan Ellis commented on CASSANDRA-6694:
---
Simple solution: leave DK and
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965562#comment-13965562
]
Benedict commented on CASSANDRA-6694:
-
Well, the only fly in that ointment is that
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963907#comment-13963907
]
Pavel Yaskevich commented on CASSANDRA-6694:
bq. I'm saying performance
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963923#comment-13963923
]
Benedict commented on CASSANDRA-6694:
-
bq. less object overhead
There is no
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964564#comment-13964564
]
Pavel Yaskevich commented on CASSANDRA-6694:
bq. The JVM instruction set
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962658#comment-13962658
]
Benedict commented on CASSANDRA-6694:
-
bq. Can we decide if we actually want to
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962679#comment-13962679
]
Pavel Yaskevich commented on CASSANDRA-6694:
If I had something more
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962691#comment-13962691
]
Benedict commented on CASSANDRA-6694:
-
bq. I think Jonathan Ellis mentioned that
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963063#comment-13963063
]
Jonathan Ellis commented on CASSANDRA-6694:
---
bq. It makes the patch more
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963100#comment-13963100
]
Benedict commented on CASSANDRA-6694:
-
Yes, but I've gutted those classes into
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963531#comment-13963531
]
Pavel Yaskevich commented on CASSANDRA-6694:
bq. More (multiple
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963619#comment-13963619
]
Benedict commented on CASSANDRA-6694:
-
bq. I'm getting mixed signals here, are you
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962580#comment-13962580
]
Pavel Yaskevich commented on CASSANDRA-6694:
I looked through the code and
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959841#comment-13959841
]
Benedict commented on CASSANDRA-6694:
-
rebased and pushed -f
Slightly More
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960112#comment-13960112
]
Jonathan Ellis commented on CASSANDRA-6694:
---
Is there a case to be made here
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960117#comment-13960117
]
Benedict commented on CASSANDRA-6694:
-
Well, it's probably indicative of something
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960187#comment-13960187
]
Benedict commented on CASSANDRA-6694:
-
Rebased, reorganised and pushed to
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960192#comment-13960192
]
Benedict commented on CASSANDRA-6694:
-
We basically have:
BBAllocator (and
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960864#comment-13960864
]
Pavel Yaskevich commented on CASSANDRA-6694:
Sorry guys, I've been busy
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958124#comment-13958124
]
Jonathan Ellis commented on CASSANDRA-6694:
---
Can you give an overview of all
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958166#comment-13958166
]
Benedict commented on CASSANDRA-6694:
-
Sure. There are now four main concepts that
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946848#comment-13946848
]
Benedict commented on CASSANDRA-6694:
-
Pushed a rebased branch against latest
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947041#comment-13947041
]
Jonathan Ellis commented on CASSANDRA-6694:
---
So our classic Cell is
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947318#comment-13947318
]
Benedict commented on CASSANDRA-6694:
-
bq. Why do we need all the Pool and
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944885#comment-13944885
]
Sylvain Lebresne commented on CASSANDRA-6694:
-
bq. I see a 25% throughput
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944889#comment-13944889
]
Benedict commented on CASSANDRA-6694:
-
This specific patch only permits larger
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944357#comment-13944357
]
Benedict commented on CASSANDRA-6694:
-
FTR, with a very simple and short
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944212#comment-13944212
]
Benedict commented on CASSANDRA-6694:
-
Patch available
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922529#comment-13922529
]
Benedict commented on CASSANDRA-6694:
-
Quick update: I realised I had accidentally
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917897#comment-13917897
]
Benedict commented on CASSANDRA-6694:
-
Pushed another update, with a slight
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916722#comment-13916722
]
Benedict commented on CASSANDRA-6694:
-
Uploaded
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909343#comment-13909343
]
Benedict commented on CASSANDRA-6694:
-
bq. My preferred solution would be, stop
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908198#comment-13908198
]
Benedict commented on CASSANDRA-6694:
-
Pushed an updated branch
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908336#comment-13908336
]
Sylvain Lebresne commented on CASSANDRA-6694:
-
I know I'll sound like a
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908521#comment-13908521
]
Jonathan Ellis commented on CASSANDRA-6694:
---
bq. The basic idea is that we
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908524#comment-13908524
]
Jonathan Ellis commented on CASSANDRA-6694:
---
NB: While I'm all for
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908537#comment-13908537
]
Benedict commented on CASSANDRA-6694:
-
bq. Not sure I follow, I only see static
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908605#comment-13908605
]
Benedict commented on CASSANDRA-6694:
-
So, at the very least we use it on each
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13904708#comment-13904708
]
Benedict commented on CASSANDRA-6694:
-
Initial patch for this is available
[
https://issues.apache.org/jira/browse/CASSANDRA-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13904728#comment-13904728
]
Jonathan Ellis commented on CASSANDRA-6694:
---
I bet [~mshuler] could help
84 matches
Mail list logo