Please review this PR and associated
[CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
parsing for NumberFormat.
The concrete subclasses that will utilize this leniency value are
`DecimalFormat` and `CompactNumberFormat`. Strict leniency allows for parsing
to be used
> In cases where the compiler needs to unbox a `long`, `float`, `double` and
> then run the exactness check, we were getting a crash. While the selector
> value is always boxed, the type (which controls the execution flow) was not,
> because the `selectorType` was wrong. This PR addresses this
On Wed, 13 Mar 2024 11:18:20 GMT, Magnus Ihse Bursie wrote:
> As part of the ongoing effort to enable jcheck whitespace checking to all
> text files, it is now time to address assembly (.S) files. The hotspot
> assembly files were fixed as part of the hotspot mapfile removal, so only a
>
On Fri, 15 Mar 2024 18:09:36 GMT, Mandy Chung wrote:
> > Wasn't the intention to make "creating a linkable runtime image" a build
> > only decision and make the relevant infrastructure classes build-only
> > artefacts?
>
> Build-only decision means that the linkable runtime image is only
On Fri, 15 Mar 2024 19:29:49 GMT, Mandy Chung wrote:
> > > If `--enable-runtime-link-image` is enabled, the JDK image does not
> > > include the packaged modules.
> >
> >
> > That's not true. Right now `--enable-runtime-link-image` modifies how the
> > `lib/modules` image looks like (adds a
Similar to [JDK-8328157](https://bugs.openjdk.org/browse/JDK-8328157), we want
to move the setting of LDFLAGS to LDFLAGS_JDK[LIB/EXE into SetupJdkLibrary and
SetupJdkExecutable.
-
Commit messages:
- 8328177: Move LDFLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
Changes:
On Sat, 16 Mar 2024 00:08:04 GMT, Sandhya Viswanathan
wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make all ALIGN/.align aligned
>
> Looks good to me.
Thanks @sviswa7!
-
PR Comment:
On Sun, 17 Mar 2024 22:53:55 GMT, Archie Cobbs wrote:
>> `GZIPInputStream`, when looking for a concatenated stream, relies on what
>> the underlying `InputStream` says is how many bytes are `available()`. But
>> this is inappropriate because `InputStream.available()` is just an estimate
>>
> # Issue
> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in JDK
> 10
>
> I changed the @\since tags to better accurately show when the methods and
> constructors were introduced.
Nizar Benalla has updated the pull request incrementally with one additional
commit
On Tue, 12 Mar 2024 14:06:11 GMT, Aggelos Biboudis
wrote:
> In cases where the compiler needs to unbox a `long`, `float`, `double` and
> then run the exactness check, we were getting a crash. While the selector
> value is always boxed, the type (which controls the execution flow) was not,
>
On Mon, 18 Mar 2024 14:35:06 GMT, Claes Redestad wrote:
> Does this change how early `Unsafe` is initialized, and does it in turn have
> dependencies on `StringUTF16`? `StringUTF16` is loaded very early, especially
> if `-XX:-CompactStrings` is supplied and I would assume the only reason this
On Mon, 18 Mar 2024 14:09:09 GMT, Per Minborg wrote:
> This PR proposes to remove the native method `StringUTF16::isBigEndian` and
> its corresponding C implementation and instead rely on the
> `jdk.internal.misc.Unsafe::isBigEndian` method.
Nice Cleanup.
-
Marked as reviewed by
On Mon, 18 Mar 2024 14:09:09 GMT, Per Minborg wrote:
> This PR proposes to remove the native method `StringUTF16::isBigEndian` and
> its corresponding C implementation and instead rely on the
> `jdk.internal.misc.Unsafe::isBigEndian` method.
Does this change how early `Unsafe` is initialized,
This task addresses an essential aspect of our testing infrastructure: the
proper handling and cleanup of temporary files and socket files created during
test execution. The motivation behind these changes is to prevent the
accumulation of unnecessary files in the default temporary directory,
Please review this simple bugfix to properly construct links to preview JEPs.
The most straightforward fix I could think of was to pass `String` rather than
`int` (`Integer`) to a method, which eventually calls
`java.text.MessageFormat.format(String, Object...)`.
For the test, I decided to be
On Mon, 18 Mar 2024 14:53:44 GMT, Pavel Rappo wrote:
> Please review this simple bugfix to properly construct links to preview JEPs.
>
> The most straightforward fix I could think of was to pass `String` rather
> than `int` (`Integer`) to a method, which eventually calls
>
On Tue, 12 Mar 2024 10:44:54 GMT, Yudi Zheng wrote:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
src/java.base/share/classes/java/math/BigInteger.java line 1836:
> 1834:
> 1835:
On Mon, 18 Mar 2024 17:24:05 GMT, Jaikiran Pai wrote:
>> Suchismith Roy has updated the pull request incrementally with seven
>> additional commits since the last revision:
>>
>> - remove space
>> - remove debug print lines
>> - remove debug print lines
>> - remove debug lines
>> -
On Wed, 13 Mar 2024 18:01:21 GMT, Roger Riggs wrote:
> The intermittent failure of ObjectStreamClassCaching is due to an incorrect
> assumption about GC behavior and a race condition.
>
> Removed test based on incorrect assumptions about simultaneous clearing of
> WeakReferences.
> Added a
On Wed, 13 Mar 2024 20:10:25 GMT, Roger Riggs wrote:
>> The intermittent failure of ObjectStreamClassCaching is due to an incorrect
>> assumption about GC behavior and a race condition.
>>
>> Removed test based on incorrect assumptions about simultaneous clearing of
>> WeakReferences.
>>
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with seven additional
commits since the last revision:
This PR proposes to remove the native method `StringUTF16::isBigEndian` and its
corresponding C implementation and instead rely on the
`jdk.internal.misc.Unsafe::isBigEndian` method.
-
Commit messages:
- Update copyright years
- Remove native method
Changes:
On Mon, 18 Mar 2024 14:53:44 GMT, Pavel Rappo wrote:
> Please review this simple bugfix to properly construct links to preview JEPs.
>
> The most straightforward fix I could think of was to pass `String` rather
> than `int` (`Integer`) to a method, which eventually calls
>
On Tue, 27 Feb 2024 08:45:12 GMT, Adam Sotona wrote:
> Task providing Class-File API transition to Second Preview.
Looks good to me.
-
Marked as reviewed by jlahoda (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18021#pullrequestreview-1943355591
On Tue, 12 Mar 2024 10:44:54 GMT, Yudi Zheng wrote:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Quite a simplification!
Have you checked if there are any performance differences?
On Mon, 18 Mar 2024 14:53:44 GMT, Pavel Rappo wrote:
> Please review this simple bugfix to properly construct links to preview JEPs.
>
> The most straightforward fix I could think of was to pass `String` rather
> than `int` (`Integer`) to a method, which eventually calls
>
On Mon, 18 Mar 2024 16:17:41 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Mon, 18 Mar 2024 18:40:36 GMT, Severin Gehwolf wrote:
> What I mean to convey is that how the directory tree in `images/jdk` looks
> like shouldn't change based on the `--enable-linkable-runtime-image`
> configure flag. That is, there will be a `images/jdk/jmods` folder unless
>
On Thu, 14 Mar 2024 23:23:07 GMT, Brent Christian wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
On Mon, 18 Mar 2024 14:09:09 GMT, Per Minborg wrote:
> This PR proposes to remove the native method `StringUTF16::isBigEndian` and
> its corresponding C implementation and instead rely on the
> `jdk.internal.misc.Unsafe::isBigEndian` method.
>
> This PR passes tier1-3 tests.
> Initialization
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
> parsing for NumberFormat.
>
> The concrete subclasses that will utilize this leniency value are
> `DecimalFormat` and `CompactNumberFormat`. Strict leniency allows for parsing
On Mon, 18 Mar 2024 16:47:24 GMT, Bill Huang wrote:
> This task addresses an essential aspect of our testing infrastructure: the
> proper handling and cleanup of temporary files and socket files created
> during test execution. The motivation behind these changes is to prevent the
>
On Mon, 18 Mar 2024 12:44:46 GMT, Nizar Benalla wrote:
>> # Issue
>> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in
>> JDK 10
>>
>> I changed the @\since tags to better accurately show when the methods and
>> constructors were introduced.
>
> Nizar Benalla has
On Mon, 18 Mar 2024 17:40:26 GMT, Mandy Chung wrote:
> A simple fix. This is caused by a bug in `VerifyAccess::isClassAccessible`
> that checks if a class is exported from `java.base` before the exports are
> fully setup.It should check if the module system is fully initialized
> before
On Tue, 19 Mar 2024 00:40:02 GMT, Y. Srinivas Ramakrishna
wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> further tweaks to reachability
>
> src/java.base/share/classes/java/lang/ref/package-info.java line
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with one additional
commit since the last revision:
On Mon, 18 Mar 2024 13:01:10 GMT, Severin Gehwolf wrote:
> Yes we do. The main reason being that the `jdk` image has more to it than
> just the image. `src.zip`, CDS data, `demo` and so on. We don't want to
> duplicate that. To us, including the `jmods` folder is something that comes
> into
On Tue, 12 Mar 2024 10:44:54 GMT, Yudi Zheng wrote:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
src/hotspot/share/opto/library_call.cpp line 5934:
> 5932: // 'y_start'
On Mon, 18 Mar 2024 17:40:26 GMT, Mandy Chung wrote:
> A simple fix. This is caused by a bug in `VerifyAccess::isClassAccessible`
> that checks if a class is exported from `java.base` before the exports are
> fully setup.It should check if the module system is fully initialized
> before
On Fri, 15 Mar 2024 15:19:17 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Sat, 16 Mar 2024 04:21:55 GMT, Stuart Marks wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> further tweaks to reachability
>
> src/java.base/share/classes/java/lang/ref/package-info.java line 127:
>
>> 125:
A simple fix. This is caused by a bug in `VerifyAccess::isClassAccessible`
that checks if a class is exported from `java.base` before the exports are
fully setup.It should check if the module system is fully initialized
before checking the module exports instead.
-
Commit
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with one additional
commit since the last revision:
On Mon, 18 Mar 2024 18:08:23 GMT, Mandy Chung wrote:
> > Yes we do. The main reason being that the `jdk` image has more to it than
> > just the image. `src.zip`, CDS data, `demo` and so on. We don't want to
> > duplicate that. To us, including the `jmods` folder is something that comes
> >
On Sat, 16 Mar 2024 04:20:44 GMT, Stuart Marks wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> further tweaks to reachability
>
> src/java.base/share/classes/java/lang/ref/Reference.java line 402:
>
>> 400:
On Mon, 18 Mar 2024 17:31:21 GMT, Suchismith Roy wrote:
> In AIX, we have an usecase where shared libraries have certain member objects
> to be referred to. E.g libclang.a(shr_64.o) .
Would you happen to know any official documentation which explains that AIX
syntax?
> When we provide the
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> -
47 matches
Mail list logo
