Re: Review Request 29467: Patch for KAFKA-1660

2015-03-02 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/#review74833 --- Ship it! LGTM. - Jiangjie Qin On March 2, 2015, 6:41 p.m.,

Re: How to get a JIRA assigned

2015-03-02 Thread Guozhang Wang
Filed INFRA-9219 for this. On Mon, Feb 23, 2015 at 5:29 AM, Joe Stein joe.st...@stealth.ly wrote: Jay, I thought it was the same issue like with confluence and comments and why we have to grant rights for that. Bots coming and reassigning everything to them or something in JIRA. We could

Re: Review Request 29467: Patch for KAFKA-1660

2015-03-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/#review74835 --- Could we add some unit tests for this new API as I mentioned in my

Re: Unit tests in java7 vs java8

2015-03-02 Thread Guozhang Wang
Here are some number I got (this is with KAFKA-1910 patch and ConsumerTest modified a bit): JDK 8 Total time: 18 mins 3.649 secs real18m4.091s user0m7.105s sys0m0.426s JDK 7 Total time: 18 mins 55.546 secs real18m55.997s user0m4.157s sys0m0.341s

Fwd: patch set 1988

2015-03-02 Thread Tong Li
Folks, Do not want to nag you, but wonder if any of you has couple of minutes to review patch set for 1988 again so that I do not have to rebase this so many times. Guozhang already +1ed(thanks Guozhang!) Here are the links for your convenience. The issue

Re: Review Request 31591: Patch for KAFKA-1992

2015-03-02 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31591/#review74827 --- Ship it! LGTM, just a minor comment.

[jira] [Created] (KAFKA-1998) Partitions Missing From MetadataResponse

2015-03-02 Thread Evan Huus (JIRA)
Evan Huus created KAFKA-1998: Summary: Partitions Missing From MetadataResponse Key: KAFKA-1998 URL: https://issues.apache.org/jira/browse/KAFKA-1998 Project: Kafka Issue Type: Bug

Re: Review Request 29467: Patch for KAFKA-1660

2015-03-02 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/#review74843 --- Actually I spoke too fast... As the flush() has been checked in, we

[jira] [Assigned] (KAFKA-1998) Partitions Missing From MetadataResponse

2015-03-02 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-1998: -- Assignee: Mayuresh Gharat Partitions Missing From MetadataResponse

Re: Unit tests in java7 vs java8

2015-03-02 Thread Gwen Shapira
I guess its just my machine then. Thanks! On Mon, Mar 2, 2015 at 2:47 PM, Guozhang Wang wangg...@gmail.com wrote: Here are some number I got (this is with KAFKA-1910 patch and ConsumerTest modified a bit): JDK 8 Total time: 18 mins 3.649 secs real18m4.091s user0m7.105s

Re: How to get a JIRA assigned

2015-03-02 Thread Neha Narkhede
Thanks Guozhang! On Mon, Mar 2, 2015 at 1:59 PM, Guozhang Wang wangg...@gmail.com wrote: Filed INFRA-9219 for this. On Mon, Feb 23, 2015 at 5:29 AM, Joe Stein joe.st...@stealth.ly wrote: Jay, I thought it was the same issue like with confluence and comments and why we have to grant

Re: Unit tests in java7 vs java8

2015-03-02 Thread Gwen Shapira
Total time: 14 mins 57.037 secs And I'm running with SSD. On Mon, Mar 2, 2015 at 4:34 PM, Jay Kreps jay.kr...@gmail.com wrote: Wow, 18 mins? I was seeing 8 mins a couple weeks ago and 12 mins now. Anyone know what's up? Not sure if the 12=18 is just because I have SSDs or what. It is really

[jira] [Comment Edited] (KAFKA-1910) Refactor KafkaConsumer

2015-03-02 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14336985#comment-14336985 ] Guozhang Wang edited comment on KAFKA-1910 at 3/3/15 12:45 AM:

[jira] [Commented] (KAFKA-902) Randomize backoff on the clients for metadata requests

2015-03-02 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344463#comment-14344463 ] Grant Henke commented on KAFKA-902: --- A few thoughts on the patch: Should the jitter be

Re: [VOTE] 0.8.2.1 Candidate 2

2015-03-02 Thread Jun Rao
+1 from me. Verified quickstart and unit tests. Thanks, Jun On Thu, Feb 26, 2015 at 2:59 PM, Jun Rao j...@confluent.io wrote: This is the second candidate for release of Apache Kafka 0.8.2.1. This fixes 4 critical issue in 0.8.2.0. Release Notes for the 0.8.2.1 release

[jira] [Updated] (KAFKA-1910) Refactor KafkaConsumer

2015-03-02 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1910: - Attachment: KAFKA-1910.patch Refactor KafkaConsumer --

[jira] [Updated] (KAFKA-1910) Refactor KafkaConsumer

2015-03-02 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1910: - Status: Patch Available (was: Open) Refactor KafkaConsumer --

Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/ --- Review request for kafka. Bugs: KAFKA-1910

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-02 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344174#comment-14344174 ] Guozhang Wang commented on KAFKA-1910: -- Created reviewboard

Re: Unit tests in java7 vs java8

2015-03-02 Thread Jay Kreps
Wow, 18 mins? I was seeing 8 mins a couple weeks ago and 12 mins now. Anyone know what's up? Not sure if the 12=18 is just because I have SSDs or what. It is really easy to make a small change that adds a few hundred ms of startup or shutdown time and that have that multiply by 500 server start

[jira] [Updated] (KAFKA-1882) Create extendable channel interface and default implementations

2015-03-02 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1882: - Status: Patch Available (was: Open) Create extendable channel interface and default implementations

[jira] [Updated] (KAFKA-1882) Create extendable channel interface and default implementations

2015-03-02 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1882: - Priority: Blocker (was: Major) Fix Version/s: 0.8.3 supported in this patch

Re: Review Request 31366: Patch for KAFKA-1461

2015-03-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review74866 --- core/src/main/scala/kafka/server/AbstractFetcherThread.scala

Re: Review Request 29467: Patch for KAFKA-1660

2015-03-02 Thread Jay Kreps
On March 2, 2015, 11:04 p.m., Jiangjie Qin wrote: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, line 219 https://reviews.apache.org/r/29467/diff/4/?file=882250#file882250line219 We probably need to release the caller threads that are waiting on

Re: Review Request 29467: Patch for KAFKA-1660

2015-03-02 Thread Jiangjie Qin
On March 2, 2015, 11:04 p.m., Jiangjie Qin wrote: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, line 219 https://reviews.apache.org/r/29467/diff/4/?file=882250#file882250line219 We probably need to release the caller threads that are waiting on

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-03-02 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344481#comment-14344481 ] Jay Kreps commented on KAFKA-1660: -- [~parth.brahmbhatt] Yeah this was exactly what I was

[jira] [Updated] (KAFKA-1973) Remove the accidentally created LogCleanerManager.scala.orig

2015-03-02 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-1973: --- Attachment: KAFKA-1973.patch Remove the accidentally created LogCleanerManager.scala.orig

[jira] [Updated] (KAFKA-1973) Remove the accidentally created LogCleanerManager.scala.orig

2015-03-02 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-1973: --- Status: Patch Available (was: Open) Removes

Re: Review Request 29467: Patch for KAFKA-1660

2015-03-02 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/#review74884 ---

Re: Review Request 29467: Patch for KAFKA-1660

2015-03-02 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/#review74897 ---

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-02 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review74895 ---

[jira] [Resolved] (KAFKA-952) a broker should unregister certain ZK watchers afte it is no longer the controller

2015-03-02 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-952. --- Resolution: Duplicate This is already fixed in KAFKA-1578. a broker should unregister certain ZK watchers

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-02 Thread Jun Rao
On Feb. 27, 2015, 7:29 p.m., Gwen Shapira wrote: Thanks for the patch, Ashish. Its shaping up to be a very useful example. Two comments: 1. I think the ser/de should be part of the example and not in common, I'm not sure integer ser/de is useful enough to be distributed with Kafka

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-02 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/#review74889 --- Ship it! This looks good assuming the other patch, centralizes the

[jira] [Commented] (KAFKA-902) Randomize backoff on the clients for metadata requests

2015-03-02 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344500#comment-14344500 ] Jay Kreps commented on KAFKA-902: - This looks good to me. I'd second Grant's comments: 1. I

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-02 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/#review74893 --- Thanks for the patch. A couple of minor comments below.

[jira] [Commented] (KAFKA-1994) Evaluate performance effect of chroot check on Topic creation

2015-03-02 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344572#comment-14344572 ] Jun Rao commented on KAFKA-1994: Ashish, The code path for creating a topic may not be

Re: Review Request 29467: Patch for KAFKA-1660

2015-03-02 Thread Jay Kreps
On March 3, 2015, 4:10 a.m., Parth Brahmbhatt wrote: Two minor changes I noted, but otherwise looks good to me. Needs some unit tests, as you mentioned. Actually one probably I didn't think of is that forceClose() leaves the in-flight requests forever incomplete. A better approach would

[jira] [Updated] (KAFKA-1996) Scaladoc error: unknown tag parameter

2015-03-02 Thread Yaguo Zhou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yaguo Zhou updated KAFKA-1996: -- Attachment: scala-doc-unknown-tag-parameter.patch Scaladoc error: unknown tag parameter

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

2015-03-02 Thread Joe Stein
Hey, I just sent out a google hangout invite to all pmc, committers and everyone I found working on a KIP. If I missed anyone in the invite please let me know and can update it, np. We should do this every Tuesday @ 2pm Eastern Time. Maybe we can get INFRA help to make a google account so we can

[jira] [Created] (KAFKA-1996) Scaladoc error: unknown tag parameter

2015-03-02 Thread Yaguo Zhou (JIRA)
Yaguo Zhou created KAFKA-1996: - Summary: Scaladoc error: unknown tag parameter Key: KAFKA-1996 URL: https://issues.apache.org/jira/browse/KAFKA-1996 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-03-02 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343109#comment-14343109 ] Tong Li commented on KAFKA-1988: [~guozhang] Yes, the o.a.k.c.c.u.Utils.abs used in few

[jira] [Updated] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-03-02 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1884: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) New Producer blocks

[jira] [Commented] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-03-02 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343294#comment-14343294 ] Manikumar Reddy commented on KAFKA-1884: Created reviewboard

[jira] [Commented] (KAFKA-1877) Expose version via JMX for 'new' producer

2015-03-02 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343275#comment-14343275 ] Manikumar Reddy commented on KAFKA-1877: Yes, version info can be exposed as JMX

[jira] [Updated] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-03-02 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1884: --- Attachment: KAFKA-1884.patch New Producer blocks forever for Invalid topic names

Re: Review Request 28481: Patch for KAFKA-1792

2015-03-02 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28481/#review74760 --- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

2015-03-02 Thread Gwen Shapira
Thanks for sending this out Joe. Looking forward to chatting with everyone :) On Mon, Mar 2, 2015 at 6:46 AM, Joe Stein joe.st...@stealth.ly wrote: Hey, I just sent out a google hangout invite to all pmc, committers and everyone I found working on a KIP. If I missed anyone in the invite please

[jira] [Created] (KAFKA-1997) Refactor Mirror Maker

2015-03-02 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-1997: --- Summary: Refactor Mirror Maker Key: KAFKA-1997 URL: https://issues.apache.org/jira/browse/KAFKA-1997 Project: Kafka Issue Type: Improvement

Re: Review Request 29467: Patch for KAFKA-1660

2015-03-02 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/#review74777 ---

Apache Samza Meetup - March 4 @6PM hosted at LinkedIn's campus in Mountain View CA

2015-03-02 Thread Ed Yakabosky
Hi all - I would like to announce the first Bay Area Apache Samza Meetuphttp://www.meetup.com/Bay-Area-Samza-Meetup/events/220354853/ hosted at LinkedIn in Mountain View, CA on March 4, 2015 @6PM. We plan to host the event every 2-months to encourage knowledge sharing collaboration in

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-02 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343488#comment-14343488 ] Jonathan Creasy commented on KAFKA-1997:

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-03-02 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-1660: Attachment: KAFKA-1660_2015-03-02_10:41:49.patch Ability to call close() with a timeout on

Re: Review Request 29467: Patch for KAFKA-1660

2015-03-02 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/ --- (Updated March 2, 2015, 6:41 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-03-02 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343552#comment-14343552 ] Parth Brahmbhatt commented on KAFKA-1660: - Updated reviewboard

[jira] [Commented] (KAFKA-902) Randomize backoff on the clients for metadata requests

2015-03-02 Thread Geoffrey Anderson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343607#comment-14343607 ] Geoffrey Anderson commented on KAFKA-902: - Created reviewboard

[jira] [Updated] (KAFKA-902) Randomize backoff on the clients for metadata requests

2015-03-02 Thread Geoffrey Anderson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Anderson updated KAFKA-902: Status: Patch Available (was: Open) Randomize backoff on the clients for metadata requests

Review Request 31633: Patch for KAFKA-902

2015-03-02 Thread Geoffrey Anderson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31633/ --- Review request for kafka. Bugs: KAFKA-902

[jira] [Updated] (KAFKA-902) Randomize backoff on the clients for metadata requests

2015-03-02 Thread Geoffrey Anderson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Anderson updated KAFKA-902: Attachment: KAFKA-902.patch Randomize backoff on the clients for metadata requests