showuon commented on PR #15732:
URL: https://github.com/apache/kafka/pull/15732#issuecomment-2068407055
@akhileshchg @mumrah @cmccabe , could you take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
showuon commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1574049613
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +123,57 @@ class AlterReplicaLogDirsRequestTest extends
BaseRequestTest {
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839452#comment-17839452
]
Sal Sorrentino edited comment on KAFKA-16514 at 4/22/24 2:13 AM:
-
IMHO:
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839452#comment-17839452
]
Sal Sorrentino edited comment on KAFKA-16514 at 4/22/24 2:10 AM:
-
IMHO:
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839452#comment-17839452
]
Sal Sorrentino commented on KAFKA-16514:
IMHO: I think if you have a replication factor of 0 and
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839441#comment-17839441
]
Matthias J. Sax commented on KAFKA-16514:
-
You are right that there is alway a member-id etc – I
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839440#comment-17839440
]
Matthias J. Sax commented on KAFKA-16567:
-
I see – this raises a few questions... Given that
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1574007862
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -173,7 +208,11 @@ private void
OmniaGM opened a new pull request, #15775:
URL: https://github.com/apache/kafka/pull/15775
- Move all Kraft configs/docs/defaults into `KRaftConfigs`.
- Note: We have already `RaftConfig` but it seems to contain limited amount
of configs that only configure `controller` raft and
OmniaGM opened a new pull request, #15774:
URL: https://github.com/apache/kafka/pull/15774
- Pull all quota configs from `KafkaConfig`, `DynamicConfig` and `LogConfig`
into `ServerQuotaConfigs` in `server-commons` as replication configs are shared
between server, storage and tools
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573897839
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
Janmm14 commented on PR #15743:
URL: https://github.com/apache/kafka/pull/15743#issuecomment-2068177862
@ijuma Apache CI might've run untrusted 3rd party code .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573880096
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2068156085
> Thanks @linu-shibu this is a lot closer to what I expected.
>
> Can you also add the build.gradle patch I mentioned earlier? I think this
is the only raw types used in the
gharris1727 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573875832
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -46,69 +44,65 @@ public class
linu-shibu commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573871668
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -46,69 +44,65 @@ public class
linu-shibu commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573870979
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -46,69 +44,65 @@ public class
chia7712 commented on PR #15772:
URL: https://github.com/apache/kafka/pull/15772#issuecomment-2068139760
```
Code Warning
FS Format string should use %n rather than \n in
org.apache.kafka.network.SocketServerConfigs.()
[Bug type VA_FORMAT_STRING_USES_NEWLINE
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573858499
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -67,13 +69,16 @@ public class ClusterConfig {
this.listenerName = listenerName;
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573857883
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -67,13 +69,16 @@ public class ClusterConfig {
this.listenerName = listenerName;
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573850333
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1573855465
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,477 @@
package org.apache.kafka.tools.consumer.group;
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573855899
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -67,13 +69,16 @@ public class ClusterConfig {
this.listenerName = listenerName;
gharris1727 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573855150
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -46,69 +44,65 @@ public class
linu-shibu commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573854456
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -65,50 +59,45 @@ protected ApiMessage
chia7712 commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573853257
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on PR #15772:
URL: https://github.com/apache/kafka/pull/15772#issuecomment-2068132025
@OmniaGM I merge #15770 first since it is a smaller PR. Please fix
conflicts. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Kuan Po Tseng created KAFKA-16595:
-
Summary: Introduce template in ClusterTests
Key: KAFKA-16595
URL: https://issues.apache.org/jira/browse/KAFKA-16595
Project: Kafka
Issue Type: Improvement
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573852618
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,48 +17,78 @@
package kafka.server
-import kafka.test.{ClusterConfig,
chia7712 merged PR #15770:
URL: https://github.com/apache/kafka/pull/15770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573851135
##
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##
@@ -46,6 +42,10 @@ public class Defaults {
public static final int
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573851263
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,48 +17,78 @@
package kafka.server
-import kafka.test.{ClusterConfig,
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573851135
##
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##
@@ -46,6 +42,10 @@ public class Defaults {
public static final int
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573851135
##
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##
@@ -46,6 +42,10 @@ public class Defaults {
public static final int
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573850333
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573850549
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,48 +17,78 @@
package kafka.server
-import kafka.test.{ClusterConfig,
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573849975
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,48 +17,78 @@
package kafka.server
-import kafka.test.{ClusterConfig,
chia7712 commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573848774
##
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##
@@ -46,6 +42,10 @@ public class Defaults {
public static final int
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573839545
##
core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java:
##
@@ -290,7 +287,7 @@ public void waitForReadyBrokers() throws
InterruptedException {
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1573834240
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -173,7 +208,11 @@ private void
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1573832025
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -16,7 +16,15 @@
*/
package
chia7712 commented on code in PR #15762:
URL: https://github.com/apache/kafka/pull/15762#discussion_r1573826054
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -1256,6 +1256,16 @@ public static class ConfigKey {
public final boolean
fvaleri commented on PR #14847:
URL: https://github.com/apache/kafka/pull/14847#issuecomment-2068086501
@showuon @mimaison I think this is now ready for review.
I think now changes are well isolated. There is no code refactoring or Kafka
configuration changes, so comparison with the
vamossagar12 commented on PR #15762:
URL: https://github.com/apache/kafka/pull/15762#issuecomment-2068083995
Thanks @chia7712 , I am thinking we can make the constructors as private and
let the users use only `define` method. Even in the AK codebase, I don't see
the constructor being used
vamossagar12 commented on code in PR #15762:
URL: https://github.com/apache/kafka/pull/15762#discussion_r1573818929
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -1256,6 +1256,15 @@ public static class ConfigKey {
public final boolean
ilyazr commented on PR #15701:
URL: https://github.com/apache/kafka/pull/15701#issuecomment-2068079457
@soarez
Hi! I've added some changes to fix those tests, but now it shows one failing
check. Could you tell me what has gone wrong now?
--
This is an automated message from the
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1573795818
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -16,7 +16,15 @@
*/
package
FrankYang0529 opened a new pull request, #15773:
URL: https://github.com/apache/kafka/pull/15773
If `file.delete.delay.ms` is zero, We call `take` even though the
`logsToBeDeleted` is empty, and `KafkaScheduler#shutdown` call `shutdown`
rather than `shudownNow`
gharris1727 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573784112
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -65,50 +59,45 @@ protected ApiMessage
evalaiyc98 commented on PR #15769:
URL: https://github.com/apache/kafka/pull/15769#issuecomment-2068055223
@chia7712 Could you help review this?
If there is a need for any further improvement, please let me know. Thanks!
--
This is an automated message from the Apache Git Service.
To
linu-shibu commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573755412
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,24 @@ protected final Map
OmniaGM opened a new pull request, #15772:
URL: https://github.com/apache/kafka/pull/15772
- Move socket configs and docs out of core and into
`org.apache.kafka.network.SocketServerConfigs`
- Move default values for socket configs into same class
### Committer Checklist (excluded
gharris1727 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573729186
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,24 @@ protected final Map
linu-shibu commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573721007
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,24 @@ protected final Map
Vedarth Sharma created KAFKA-16594:
--
Summary: Add a test to detect CDS errors
Key: KAFKA-16594
URL: https://issues.apache.org/jira/browse/KAFKA-16594
Project: Kafka
Issue Type: Sub-task
VedarthConfluent opened a new pull request, #15771:
URL: https://github.com/apache/kafka/pull/15771
Fix CDS in docker image.
Due to difference in packages present when jsa files were generated and when
docker image is generated, there is a log on starting docker image.
OmniaGM opened a new pull request, #15770:
URL: https://github.com/apache/kafka/pull/15770
- Move docs to PasswordEncoderConfigs
- Renamed the configs in `PasswordEncoderConfigs` to match `_CONFIG` suffix
pattern
- Move default values to `PasswordEncoderConfigs`
- Replace
evalaiyc98 opened a new pull request, #15769:
URL: https://github.com/apache/kafka/pull/15769
I am a newbie and this is a minor change that use `assertInstanceOf` to
replace the `assertTrue`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
[
https://issues.apache.org/jira/browse/KAFKA-16550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16550:
--
Assignee: JiaChi Wang (was: Chia-Ping Tsai)
> add integration test for
[
https://issues.apache.org/jira/browse/KAFKA-16550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839369#comment-17839369
]
JiaChi Wang commented on KAFKA-16550:
-
Hi [~chia7712] I'm interested in this issue. Can I take this
dboyliao commented on PR #15768:
URL: https://github.com/apache/kafka/pull/15768#issuecomment-2067968427
The blockers here are `testClusterTooOldToHaveId` and `testUnregisterBroker`.
As for `testClusterTooOldToHaveId`, I'm trying which metadata version is old
enough to be identified as
[
https://issues.apache.org/jira/browse/KAFKA-16551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839367#comment-17839367
]
Yin Chen Liao commented on KAFKA-16551:
---
I want to take over this issue.
> add integration test
chia7712 commented on PR #15616:
URL: https://github.com/apache/kafka/pull/15616#issuecomment-2067966296
> thanks for the great suggestion. I took a look LogSegment#deleteIfExists
and LogSegment#deleteTypeIfExists. If we want to handle fallback deletion in
LocalLog, we may need to return
The-Gamer-01 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573677249
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,24 @@ protected final Map
brandboat commented on code in PR #15764:
URL: https://github.com/apache/kafka/pull/15764#discussion_r1573667382
##
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##
@@ -267,7 +267,7 @@ class KRaftMetadataCache(val brokerId: Int) extends
MetadataCache with
charliecheng630 opened a new pull request, #15767:
URL: https://github.com/apache/kafka/pull/15767
- suppress the warnings from RemoteLogManager
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [x] Verify test coverage and CI build
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1573652117
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +118,57 @@ class AlterReplicaLogDirsRequestTest extends
FrankYang0529 commented on PR #15616:
URL: https://github.com/apache/kafka/pull/15616#issuecomment-2067936507
> This PR is good but it seems to me `LogSegment` should NOT guess the
directory structure managed by upper class (i.e `LogManager`).
>
> It seems the root cause is caused by
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573635829
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,48 +17,78 @@
package kafka.server
-import kafka.test.{ClusterConfig,
frankvicky opened a new pull request, #15766:
URL: https://github.com/apache/kafka/pull/15766
Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 commented on code in PR #15765:
URL: https://github.com/apache/kafka/pull/15765#discussion_r1573633727
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -463,7 +464,9 @@ private Optional
lookupTimestamp(RemoteLogSegmen
RecordBatch
m1a2st commented on PR #15765:
URL: https://github.com/apache/kafka/pull/15765#issuecomment-2067922075
@chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/KAFKA-16547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-16547:
-
Assignee: Ming-Yen Chung (was: Yu-Lin Chen)
> add test for
[
https://issues.apache.org/jira/browse/KAFKA-16547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839323#comment-17839323
]
Ming-Yen Chung commented on KAFKA-16547:
Hi [~chia7712],
I would like to do it as my first
74 matches
Mail list logo
