To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=5226
------- Additional comments from [EMAIL PROTECTED] Wed Apr 16 17:06:58 +0000 2008 ------- @mba: >If we never disabled the "Save" button - why should we disable any button? We could always enable the "paste" button even if the clipboard is empty. Or the "undo" button, or ... It all comes down to how simple or complex the criteria is to disable an icon. It's relatively simple to determine whether the clipboard is empty for the paste icon, or where the current position is in the undo stack for the undo/redo icons. For the save icon, the criteria is "whether or not the document has been modified". It's such a simple question but hard to answer accurately, and I hope you already know the reason why. Even for the paste icon, it is extremely hard to be accurate on whether the clipboard is really empty simply because you could always copy something in another application. To get the state of the system clipboard always right, OOo must query the system clipboard state at regular intervals. Given that, it's certainly easier and more efficient to always enable the paste icon, then once the user requests a paste action, query the clipboard to see if it's empty. This would avoid wasteful polling of the system clipboard, and keep the code complexity lower. (Actually I just found out that OOo disables the paste icon when it thinks the clipboard is empty, but copying something in another application does not re-enable it. Is this a bug or a feature? ;-) ) For the undo/redo buttons, I can think of one situation where getting the state of the undo stack is not straight-forward; when it involves editing of charts. But other than that, the criteria is pretty simple; when the current position is at the top of the stack, enable undo and disable redo, when it's at the bottom of the stack, disable undo and enable redo, when it's somewhere in the middle, enable both icons. So, back to the Save icon. It all comes down to how easy/difficult to accurately determine the document modified state. You would have to answer many other questions before you can answer it reliably: what does a document include? is view data a part of the document, if yes, which view data should be part of the document, if no, should modifying the view data trigger the document to be modified? If the view data should not trigger the document to be modified, should they be saved with the file? etc. Any sophisticated applications save the view data and other accessory data that are not part of the core document to the file on disk. But because of this, it is extremely hard and (to me) no longer realistic to disable the save action at correct time in such a way to satisfy all users. Having said that, I can see I'm in the minority in this part of the world. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
