Thanks Yoav! This intent only covers the unprefixing. Further interop improvements will come later.
Regards, Traian On Wed, Dec 7, 2022 at 3:37 AM Yoav Weiss <yoavwe...@chromium.org> wrote: > LGTM1 > > Thanks for working on this!! Looking at wpt.fyi, other implementations are > passing the test suite for this to varying degrees. Does this intent cover > full compliance with the test suite? (e.g. `type()`, `url()`, non `x` > descriptors, and maybe other dimensions) Or does it only cover the > unprefixing and further interop improvements will come later? > > On Tuesday, December 6, 2022 at 3:23:32 AM UTC+1 Traian Captan wrote: > >> Contact emailstcap...@chromium.org >> >> ExplainerNone >> >> Specification >> https://w3c.github.io/csswg-drafts/css-images-4/#image-set-notation >> >> Summary >> >> Unprefix -webkit-image-set to expose the current image-set functionality >> without needing the '-webkit-' prefix. >> >> >> Blink componentBlink >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink> >> Motivation >> >> Currently Blink only supports '-webkit-' prefixed image-set, while Gecko >> and WebKit support both prefixed and unprefixed versions. With this change >> interop with Gecko and WebKit will be increased by allowing web developers >> to use the current Blink image-set functionality both with and without the >> '-webkit-' prefix. >> >> Search tagsimage-set <https://chromestatus.com/features#tags:image-set> >> >> TAG reviewSkipping because this is a straightforward interop fix. >> >> TAG review statusNot applicable >> >> Risks >> >> >> Interoperability and Compatibility >> >> The Interoperability Risk is Low. This change increases interop with >> Gecko and WebKit which already support both '-webkit-' prefixed and >> unprefixed image-set. The Compatibility Risk is Low. If both prefixed and >> standard versions are defined in the right order, and the standard version >> fails parsing, Blink will fallback to the prefixed version. The >> 'image-set-fallback' test has been added to verify this behavior. >> >> >> *Gecko*: Shipped/Shipping ( >> https://hg.mozilla.org/integration/autoland/rev/5c09b1d070e2) >> >> *WebKit*: Shipped/Shipping ( >> https://trac.webkit.org/changeset/202765/webkit) >> >> *Web developers*: Strongly positive - This issue has been Starred by 55 >> users. >> >> *Other signals*: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> No >> >> >> Debuggability >> >> N/A >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, Chrome OS, Android, and Android WebView)?Yes >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ?Yes >> https://wpt.fyi/results/css/css-images/image-set >> >> Flag nameCSSImageSet >> >> Requires code in //chrome?False >> >> Tracking bughttps://crbug.com/630597 >> >> Estimated milestones >> >> 110 Or 111 >> >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> None >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/5109745420075008 >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFxahvth292nfHhu8RhC9u5LhfQa3FBNZ-YtWxAjkymKHox7iQ%40mail.gmail.com.