Thanks Yoav!
On Wed, Mar 8, 2023 at 1:53 AM Yoav Weiss <yoavwe...@chromium.org> wrote: > My LGTM1 still stands! :) > > On Wed, Mar 8, 2023 at 8:40 AM Traian Captan <tcap...@chromium.org> wrote: > >> Hi, >> >> Following the previous conversation, we worked on adding support for the >> missing functionality that is currently described in the image-set spec >> <https://w3c.github.io/csswg-drafts/css-images-4/#image-set-notation>. >> >> Here is the updated intent: >> >> Contact emailstcap...@chromium.org >> >> ExplainerNone >> >> Specification >> https://w3c.github.io/csswg-drafts/css-images-4/#image-set-notation >> >> Summary >> >> Unprefix -webkit-image-set to expose the current image-set functionality >> without needing the '-webkit-' prefix, and add support for the >> functionality currently described in the image-set spec. >> >> >> Blink componentBlink >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink> >> >> Search tagsimage-set <https://chromestatus.com/features#tags:image-set> >> >> TAG reviewSkipping because this is a straightforward interop fix. >> >> TAG review statusNot applicable >> >> Risks >> >> >> Interoperability and Compatibility >> >> The Interoperability Risk is Low. This change increases interop with >> Gecko and WebKit which already support both '-webkit-' prefixed and >> unprefixed image-set, and are also actively working on improving their >> image-set implementations as part of Interop 2023 efforts. The >> Compatibility Risk is Low. >> >> >> *Gecko*: Shipped/Shipping ( >> https://hg.mozilla.org/integration/autoland/rev/5c09b1d070e2) >> >> *WebKit*: Shipped/Shipping ( >> https://trac.webkit.org/changeset/202765/webkit) >> >> *Web developers*: Strongly positive This issue has been Starred by 55 >> users. >> >> *Other signals*: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> No >> >> >> Debuggability >> >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, Chrome OS, Android, and Android WebView)?Yes >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ?Yes >> > > Even though wpt.fyi > <https://wpt.fyi/results/css/css-images/image-set/image-set-computed.sub.html?label=experimental&label=master&aligned> > is reddish, I'm seeing all the tests pass on ToT. Thank you!! > > >> >> Flag nameCSSImageSet >> >> Requires code in //chrome?False >> >> Tracking bughttps://crbug.com/630597 >> >> Estimated milestones >> >> No milestones specified >> >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> None >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/5109745420075008 >> >> Links to previous Intent discussionsIntent to Ship: >> https://groups.google.com/a/chromium.org/g/blink-dev/c/JXcRP4MJc9I >> >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> >> Regards, >> Traian >> >> >> On Mon, Jan 23, 2023 at 2:57 PM Traian Captan <tcap...@chromium.org> >> wrote: >> >>> Thanks Noam! >>> >>> I'll add support for the other cases behind the feature flag and we'll >>> ship it when we are "interoperable enough". >>> >>> Regards, >>> Traian >>> >>> >>> On Wed, Dec 14, 2022 at 6:41 AM Noam Rosenthal <nrosent...@chromium.org> >>> wrote: >>> >>>> >>>> >>>> On Wed, Dec 14, 2022 at 2:28 PM Manuel Rego Casasnovas <r...@igalia.com> >>>> wrote: >>>> >>>>> If we have plans to fix issues on this feature later, why not fixing >>>>> them before and then shipping when things look good? >>>>> >>>>> If we unprefix it, it'll kind of appear as a new Chromium feature that >>>>> people can use, and they will expect it follows the spec. >>>> >>>> >>>> I agree, for example people might (wrongfully) rely on >>>> CSS.supports("background-image", "image-set(url(example.jpg) 1x)") >>>> to mean that the full set of image-set features is supported. >>>> I'm not sure people are more granular than that about feature detection >>>> but we probably have data about that. >>>> >>>> It might be wise to support the cases behind the prefix, and >>>> unprefix when the behavior is close to complete and interoperable enough. >>>> We don't need to rely on people posting bug reports when we know the >>>> issues today by looking at the WPT failures. >>>> >>> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFxahvuj9a4XgW9MUQRi-0WTEnk-5PijmoAtgEB85A5M40xj0g%40mail.gmail.com.
