On Thu, 5 Mar 2026 04:34:26 GMT, Greg Lewis <[email protected]> wrote:
>> Harald Eilertsen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Break too long lines >> >> This work was sponsored by: The FreeBSD Foundation > > make/autoconf/platform.m4 line 498: > >> 496: if test "x$OPENJDK_$1_OS" = xbsd -o "x$OPENJDK_$1_OS" = xlinux \ >> 497: && test "x$OPENJDK_$1_CPU" = xx86; then >> 498: # On linux and BSD only, we replace x86 with i386. > > This should probably use `||` rather than `-o` I thought about that too, but one advantage of using `-o` is that we don't need to add parenthesis. I'm happy either way, so just left it as it was. ------------- PR Review Comment: https://git.openjdk.org/bsd-port/pull/3#discussion_r2889115132
