On Thu, 5 Mar 2026 13:16:06 GMT, Harald Eilertsen <[email protected]> wrote:

>> This basically allows configure to complete and set up a configuration 
>> suitable for building the BSD port for supported platforms (FreeBSD, OpenBSD 
>> and NetBSD.)
>> 
>> The flag `_BSDONLY_SOURCE` is defined for all the BSD's _except_ for Apple 
>> MacOS, while the existing `_ALLBSD_SOURCE` _includes_ Apple MacOS.
>> 
>> For the BSD's we set the `OPENJDK_TARGET_OS_ENV` variable to distinct values 
>> reflecting the BSD variant being built. This is used to distinguish build 
>> flags, library locations and what libraries and modules to include for the 
>> various builds.
>> 
>> As an example, FreeBSD includes the ALSA library, and should build the 
>> Serviceability Agent, while the other BSD's do not.
>> 
>> This work was sponsored by: The FreeBSD Foundation
>
> Harald Eilertsen has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Don't build SA for other BSD's than FreeBSD
>   
>   This work was sponsored by: The FreeBSD Foundation

Hi,

It would be great if we could run the checks in these pull requests, so as to 
ensure that the changes in the `bsd-port` don't break current builds on other 
platforms.

One easy way to do that is to create a fork of this repository, enable the 
"Github Actions" in the fork (that's done in the `Checks` tab of the fork, 
IIRC) and then create a branch there with the changes and a pull request from 
that branch.

-------------

PR Comment: https://git.openjdk.org/bsd-port/pull/3#issuecomment-4022313242

Reply via email to