On Thu, 5 Mar 2026 04:33:22 GMT, Greg Lewis <[email protected]> wrote:
>> Harald Eilertsen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Break too long lines >> >> This work was sponsored by: The FreeBSD Foundation > > make/autoconf/jdk-options.m4 line 196: > >> 194: if test "x$OPENJDK_TARGET_OS_ENV" = xbsd.netbsd ; then >> 195: INCLUDE_SA=false >> 196: fi > > Maybe we should do this with `||` rather than a separate conditional like we > have in other spots in the file? I agree! Maybe even: if test "x$OPENJDK_TARGET_OS" = xbsd && test "x$OPENJDK_TARGET_OS_ENV" != xbsd.freebsd then At least if there's no plans for supporting the Serviceability Agent on any of the other BSD's. ------------- PR Review Comment: https://git.openjdk.org/bsd-port/pull/3#discussion_r2889143129
