On Thu, 17 Nov 2022 06:36:50 GMT, Julian Waters <[email protected]> wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options that still use AC_ARG_WITH in jdk-version.m4. >> They are out of the scope of this commit, which aims only to rework the >> previous integrated commits mentioned above. > > Julian Waters has updated the pull request incrementally with one additional > commit since the last revision: > > Uh oh I've found the reason after headbanging for quite a while: `DESC: [Set vendor name. Among others, used to set the 'java.vendor' and 'java.vm.vendor' system properties.]` It's the comma in between "Among others, used to set...". This seems like a general flaw in UTIL_ARG_WITH and (I believe?) more fundamentally in UTIL_DEFUN_NAMED. I could rewrite the message itself to not have the comma and bypass this entirely, but I'll refrain from doing so since I doubt you'd want this bug to continue persisting silently where it might end up rearing its ugly head when it's used again in future commits ------------- PR: https://git.openjdk.org/jdk/pull/11020
