I agree. Every clobber means we have a dependency bug. I would prefer that
we track and fix those bugs than get desensitized to them.
--Amanda
On Tue, Aug 11, 2009 at 1:45 AM, Aaron Boodman <a...@chromium.org> wrote:
>
> Such a system does not help when people sync your change. We should
> invest the effort we would expend building this system fixing the
> dependency issues.
>
> Barring that, we have a hack that we do where for resource files we
> make a whitespace change to the corresponding .gyp. We could automate
> this by having a presubmit check that enforces this.
>
> - a
>
> On Mon, Aug 10, 2009 at 10:16 PM, Jeremy Orlow<jor...@chromium.org> wrote:
> > We really need a better way to submit patches that we know require a
> > clobber. Today alone, there were 2 WebKit deps rolls that we _knew_
> would
> > need a clobber. Both ended up closing the tree for a bit.
> > What if we added an optional flag to the CL descriptions that tells the
> bots
> > that a clobber is necessary? Maybe just CLOBBER=blah where blah is the
> > platforms that require it split by commas and/or spaces? So, for
> example,
> > my CL might look like:
> > """
> > This is a really nice CL, but it touches files that confuse the
> dependency
> > tracking system on Windows and linux.
> > TEST=none
> > BUG=none
> > CLOBBER=win, linux
> > """
> > Would this be terribly hard? Any major downsides?
> > J
> > >
> >
>
> >
>
--
"Portability is generally the result of advance planning rather than trench
warfare involving #ifdef" -- Henry Spencer (1992)
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
