Ok the fix is in.If anyone sees similar behavior again, please let me know.
-BradN
On Tue, Aug 11, 2009 at 4:05 PM, Jeremy Orlow <jor...@chromium.org> wrote:
> Nice!!!
>
> On Tue, Aug 11, 2009 at 3:57 PM, Bradley Nelson <bradnel...@google.com>wrote:
>
>> Ok I think I've found it.It looks like a bug in the rule -> makefile
>> emitter which is only used for webcore.
>> (Most gyp rules turn into custom build rules, but we added a makefile
>> emitter option for this one because the native rules were too slow).
>> It appears that the custom build step for the makefile didn't get any of
>> the dependencies on the inputs (oddly the makefile itself does have them).
>> Filing bug against gyp. Working on fix...
>>
>> -BradN
>>
>>
>> On Tue, Aug 11, 2009 at 8:03 AM, Mark Mentovai <m...@chromium.org> wrote:
>>
>>> Dimitri Glazkov wrote:
>>> > The culprit here was the change to the CodeGeneratorV8.pm. It looks
>>> > like we should somehow trigger clobber of of rule_binding.py when that
>>> > happens.
>>>
>>> We already do. In the .idl rule in webkit.gyp, we have:
>>>
>>> 'inputs': [
>>>
>>> '../third_party/WebKit/WebCore/bindings/scripts/generate-bindings.pl',
>>>
>>> '../third_party/WebKit/WebCore/bindings/scripts/CodeGenerator.pm',
>>>
>>> '../third_party/WebKit/WebCore/bindings/scripts/CodeGeneratorV8.pm',
>>> '../third_party/WebKit/WebCore/bindings/scripts/IDLParser.pm',
>>>
>>> '../third_party/WebKit/WebCore/bindings/scripts/IDLStructure.pm',
>>> ],
>>>
>>> meaning that if any of those files changes, or an .idl file changes,
>>> we'll run generate-bindings.pl again.
>>>
>>> Mark
>>>
>>
>>
>> >>
>>
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
