On Tue, 24 Oct 2023 18:35:31 GMT, Harshitha Onkar <[email protected]> wrote:

>> Harfbuzz upgraded from 7.2.0 to 8.2.2
>> 
>> - 3 new files added - hb-subset-instancer-solver.cc, 
>> hb-subset-instancer-solver.hh, hb-subset-plan-member-list.hh
>> - 2 files deleted - hb-subset-cff1.hh, hb-subset-cff2.hh
>> - 173 files modified.
>
> Harshitha Onkar has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   removed not needed DISABLED_WARNINGS flag for clang

make/modules/java.desktop/lib/Awt2dLibraries.gmk line 503:

> 501:    # expansion-to-defined required for GCC 9 builds. Not required for 
> GCC 10+.
> 502:    HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := class-memaccess noexcept-type 
> expansion-to-defined dangling-reference
> 503:    HARFBUZZ_DISABLED_WARNINGS_clang := missing-field-initializers

Removed `range-loop-analysis` disabled warning flag for clang. macOS build 
works with this change.

CI build works without array-bounds,  parentheses for 
HARFBUZZ_DISABLED_WARNINGS_gcc but since these flags were added recently to 
make build work on specific gcc versions [ 
[PR#14996](https://github.com/openjdk/jdk/pull/14996/files) and 
[PR#13859](https://github.com/openjdk/jdk/pull/13859/files) ], retaining it 
as-is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16322#discussion_r1370667019

Reply via email to