On Wed, 25 Oct 2023 18:00:58 GMT, Harshitha Onkar <[email protected]> wrote:
>> It depends. Perhaps the code that triggered the warning is no longer the >> same ? >> And we just moved to xcode 14 didn't we ? So xcode 12 is now 2 versions back. >> What you could try is to take a repo WITHOUT the new version of harfbuzz (ie >> one without your PR), >> remove the disabling of this warning and see if xcode 14 build it - if it >> does, then the issue is resolved by >> the new xcode and we may still need it for the new change. If the problem is >> still there with xcode 14 and the old (ie current existing) code, then its >> resolved by the hb update and we definitely don't need it. > > @prrace Makes sense! Thank you for the info about how this can be > double-checked. I'll check and update the disabled section accordingly. With existing harfbuzz v7.2.0 (without the update) + Xcode 14 build passes which implies that the issue was resolved on Xcode 14 and not harfbuzz. Hence adding back `range-loop-analysis` disabled warning. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16322#discussion_r1372245358
