On Wed, 25 Oct 2023 17:49:43 GMT, Phil Race <[email protected]> wrote:
>> @jayathirthrao >> >> Removed `range-loop-analysis` as part of cleaning up the disabled warning >> section. I see that the following flag was added as part of >> https://github.com/openjdk/jdk/pull/993 to disable warnings for clang on >> Xcode 12. >> Details here: https://github.com/openjdk/jdk/pull/993#issuecomment-722382063. >> >> I suppose we need to add it back then? > > It depends. Perhaps the code that triggered the warning is no longer the same > ? > And we just moved to xcode 14 didn't we ? So xcode 12 is now 2 versions back. > What you could try is to take a repo WITHOUT the new version of harfbuzz (ie > one without your PR), > remove the disabling of this warning and see if xcode 14 build it - if it > does, then the issue is resolved by > the new xcode and we may still need it for the new change. If the problem is > still there with xcode 14 and the old (ie current existing) code, then its > resolved by the hb update and we definitely don't need it. @prrace Makes sense! Thank you for the info about how this can be double-checked. I'll check and update the disabled section accordingly. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16322#discussion_r1372132481
