On Tue, 24 Oct 2023 18:38:27 GMT, Harshitha Onkar <[email protected]> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed not needed DISABLED_WARNINGS flag for clang > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 503: > >> 501: # expansion-to-defined required for GCC 9 builds. Not required for >> GCC 10+. >> 502: HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := class-memaccess noexcept-type >> expansion-to-defined dangling-reference >> 503: HARFBUZZ_DISABLED_WARNINGS_clang := missing-field-initializers > > Removed `range-loop-analysis` disabled warning flag for clang. macOS build > works with this change. > > CI build works without array-bounds, parentheses for > HARFBUZZ_DISABLED_WARNINGS_gcc but since these flags were added recently to > make build work on specific gcc versions [ > [PR#14996](https://github.com/openjdk/jdk/pull/14996/files) and > [PR#13859](https://github.com/openjdk/jdk/pull/13859/files) ], retaining it > as-is. Any specific reason why we need to remove `range-loop-analysis` flag as part of this update? Were there any build issues? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16322#discussion_r1371138825
