On Wed, 25 Oct 2023 04:29:28 GMT, Jayathirth D V <[email protected]> wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 503: >> >>> 501: # expansion-to-defined required for GCC 9 builds. Not required for >>> GCC 10+. >>> 502: HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := class-memaccess noexcept-type >>> expansion-to-defined dangling-reference >>> 503: HARFBUZZ_DISABLED_WARNINGS_clang := missing-field-initializers >> >> Removed `range-loop-analysis` disabled warning flag for clang. macOS build >> works with this change. >> >> CI build works without array-bounds, parentheses for >> HARFBUZZ_DISABLED_WARNINGS_gcc but since these flags were added recently to >> make build work on specific gcc versions [ >> [PR#14996](https://github.com/openjdk/jdk/pull/14996/files) and >> [PR#13859](https://github.com/openjdk/jdk/pull/13859/files) ], retaining it >> as-is. > > Any specific reason why we need to remove `range-loop-analysis` flag as part > of this update? Were there any build issues? @jayathirthrao I removed `range-loop-analysis` as part of cleaning up the disabled warning section. I see that the following flag was added as part of https://github.com/openjdk/jdk/pull/993 to disable warnings for clang on Xcode 12. Details here: https://github.com/openjdk/jdk/pull/993#issuecomment-722382063. I suppose we need to add it back then? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16322#discussion_r1372084539
