Patrick Gansterer wrote: > Hi, > > at first: Sorry for the very long delay.
I do not really care for this, but just some minor stylistic nitpicks: -in Modules/Platform/Windows-cl.cmake you initialize some variables in both branches of an if(). You should keep the order you set them the same in both branches as is makes comparing this much easier. -you don't set CMAKE_DEBUG_PLATFORM_DEFINES for WinCE. I don't know if that is a bug or intentional. If it is a bug then set it, otherwise I would add a comment why this isn't needed. Eike --
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
