Hi, Am 14.07.2012 um 22:08 schrieb David Cole:
> On Sat, Jul 14, 2012 at 3:30 PM, Patrick Gansterer <par...@paroga.com> wrote: > Hi, > > > On Sat, 14 Jul 2012 21:08:24 +0200, Rolf Eike Beer wrote: > -in Modules/Platform/Windows-cl.cmake you initialize some variables in both > branches of an if(). You should keep the order you set them the same in both > branches as is makes comparing this much easier. > > Where exactly? I don't find it. :-/ > > > -you don't set CMAKE_DEBUG_PLATFORM_DEFINES for WinCE. I don't know > if that is > a bug or intentional. If it is a bug then set it, otherwise I would add a > comment why this isn't needed. > > The WinCE compier has no support for /RTC1. > > This patch also includes the changes mentioned in > http://public.kitware.com/pipermail/cmake-developers/2011-November/002510.html. > > -- Patrick > > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers > > > Patrick, > > Thanks for your work on this. I'll review this stuff on Monday or Tuesday and > apply the patches and merge to next if all looks well. > > Part of the problem I've always had with "other platform" support on Windows > or Visual Studio is that we have literally ZERO dashboard coverage of these > platforms. > > Is there any way you (or somebody else who cares about these platforms) can > set up a CMake dashboard to test the platform and to make sure that it > submits nightly so that if we change something surrounding this code, we have > a chance at catching unintended breakages *before* we make a CMake release? I'll have a look at it and try to set something up. > > This thread, or one like it, probably deserves a cc to the users list as well > to see if somebody there can submit such dashboards. From the activity in > mantis, it does seem to be a popular issue. Lots of folks will be glad to see > stuff like this go in. -- Patrick
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
