On Tue, Aug 21, 2012 at 5:34 PM, David Cole <david.c...@kitware.com> wrote:
> On Tue, Aug 21, 2012 at 1:33 PM, David Cole <david.c...@kitware.com>wrote: > >> On Tue, Aug 21, 2012 at 12:34 PM, Patrick Gansterer <par...@paroga.com>wrote: >> >>> Hi, >>> >>> >>> On Tue, 21 Aug 2012 12:04:50 -0400, David Cole wrote: >>> >>>> Which particular patches are you talking about? Are there issues with >>>> patches that are on the 2.8.10 roadmap yet? >>>> >>> >>> About the patches I posted a few weeks ago. I don't see them in master >>> or next branch. So my question is, how the can get there. >>> Maybe you can apply at least apply the "cleanup" patches, which don't >>> add any new behaviour, so that I can get rid of "non official" changes. >>> (E.g. "Cleanup AddPlatformDefinitions() of Visual Studio generators") >> >> >> OK -- I forgot I had tested those for you before the 2.8.9 release, but >> we had test failures on those dashboards that I didn't track down at the >> time. >> >> I'll re-run some dashboards right now on hut11.kitware again based on the >> current 'master' branch first to get a baseline. >> >> > I've done this much, and we have have some results from hut11.kitware > today (6 dashboards) that are based on current 'origin/master' > > > Then I'll point the source tree to your latest branch from your github and >> run them again so we can compare apples to apples. >> > > I'm doing this now, but it's going to be a few hours until they are all > done. I've rebased your changes on top of today's origin/master, and > resolved the conflicts that I got. I pushed it here in the meantime if > anybody else wants to review it or pick it up for testing: > https://github.com/dlrdave/CMake/compare/ce > > > >> >> *Then* I can answer the question about when we can get them into 'next' >> and 'master'... :-) >> >> > Just have to await the results now, and talk through it when they get here. > > > >> >> >>> >>> >>> I might be able to help you set up a machine for a dashboard. We >>>> should probably have a subset of the test suite that gets executed >>>> specifically for cross-compiling scenarios. (Setting up a dashboard is >>>> easy; making sure it's testing what we want tested here may be a bit >>>> more difficult...) >>>> >>> >>> I don't see much problem in setting up a machine for dashboard. The >>> problem I see is the cross-compilation stuff. >>> I'd like to add the required pices for WinCE, but unfortunately I don't >>> have the time to implement the whole cross compiling stuff into the test >>> suite. Or at least I haven't found the correct place for the change(s) yet, >>> so it works for the new generator. >> >> >> >> I'm hoping Alex chimes in here with some good advice for executing a >> cross-compiling toolchain as a dashboard test. >> >> >> Thanks for your patience, >> David >> >> > Brad merged one of your commits to 'next' today. [ http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2c7a451de003782b1ba5e47ab377f33f1fa5c4e5 ] He's coincidentally working on getting compiler ID uniform everywhere at the moment, and so it was easiest for him to take that change first and base other work on that. After things settle from his changes, we'll come back and visit the WindowsCE specific portions of your topic branch. Thanks for your patience, David
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers