[
https://issues.apache.org/jira/browse/CASSANDRA-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218611#comment-17218611
]
Adam Holmberg commented on CASSANDRA-16183:
-------------------------------------------
in-jvm dtests present a bit of a roadblock for this set of metrics, in the fact
that they [disable MBean
registration|https://github.com/apache/cassandra-in-jvm-dtest-api/blob/trunk/src/main/java/org/apache/cassandra/distributed/api/ICluster.java#L99].
This means that in order to test these metrics I would need to make the
[metrics in
StorageProxy|https://github.com/apache/cassandra/blob/095540d54a07d2c35bd9260e065fcf346ad36164/src/java/org/apache/cassandra/service/StorageProxy.java#L185-L192]
public/VisibleForTesting and reach in using
{IInvocableInstance::callsOnInstance}. This seems to work, but it's made more
painful because the metrics classes are not serializable. We would need to
marshal into a new structure to get the results back (so far have not found a
way to get any custom class across). I haven't found a great way to do this
that isn't coupled and brittle.
It's starting to feel like Python dtest might be the way to go with this.
Please let me know if anyone has further thoughts.
> Add tests to cover ClientRequest metrics
> -----------------------------------------
>
> Key: CASSANDRA-16183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16183
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Benjamin Lerer
> Assignee: Adam Holmberg
> Priority: Normal
> Fix For: 4.0-beta
>
>
> We do not have test that covers the ClientRequest metrics.
> * ClientRequestMetrics
> * CASClientRequestMetrics
> * CASClientWriteRequestMetrics
> * ClientWriteRequestMetrics
> * ViewWriteMetrics
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
