[
https://issues.apache.org/jira/browse/CASSANDRA-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229253#comment-17229253
]
Andres de la Peña commented on CASSANDRA-16183:
-----------------------------------------------
Thanks, the changes look good to me. As for the nominal tests, if I'm
understanding them correctly, they repeatedly run a query with a certain
consistency level and verify both the metric for that consistency level and the
global read/write metric. Also, the tests do some validation in the metrics of
the not used consistency levels. {{write_nominal}} uses CL=ONE and
{{read_nominal}} uses CL=LOCAL_ONE. I think that in both tests we can easily
test the mbeans for some more consistency in levels by just calling
{{validate_nominal}} with those consistency levels, just to check that the
corresponding CL metric is updated. Do you think it makes any sense, or am I
missing something?
> Add tests to cover ClientRequest metrics
> -----------------------------------------
>
> Key: CASSANDRA-16183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16183
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Benjamin Lerer
> Assignee: Adam Holmberg
> Priority: Normal
> Fix For: 4.0-beta
>
>
> We do not have test that covers the ClientRequest metrics.
> * ClientRequestMetrics
> * CASClientRequestMetrics
> * CASClientWriteRequestMetrics
> * ClientWriteRequestMetrics
> * ViewWriteMetrics
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
