[ https://issues.apache.org/jira/browse/CASSANDRA-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228820#comment-17228820 ]
Adam Holmberg commented on CASSANDRA-16183: ------------------------------------------- Thanks for the review. I pushed a commit with most of the suggested tweaks. One exception, I left the nominal tests as-written to see if you had any further thoughts on this bit: https://github.com/aholmberg/cassandra-dtest/pull/1#discussion_r518930951 > Add tests to cover ClientRequest metrics > ----------------------------------------- > > Key: CASSANDRA-16183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16183 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java > Reporter: Benjamin Lerer > Assignee: Adam Holmberg > Priority: Normal > Fix For: 4.0-beta > > > We do not have test that covers the ClientRequest metrics. > * ClientRequestMetrics > * CASClientRequestMetrics > * CASClientWriteRequestMetrics > * ClientWriteRequestMetrics > * ViewWriteMetrics -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org