[
https://issues.apache.org/jira/browse/CASSANDRA-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227005#comment-17227005
]
Adam Holmberg commented on CASSANDRA-16183:
-------------------------------------------
That was... more involved than I was expecting. Lots of metrics, interference,
and developing techniques to make them happen. I think I came up with something
reasonably compact that exercises them.
[Here|https://github.com/apache/cassandra-dtest/compare/trunk...aholmberg:CASSANDRA-16183]
is a potential patch containing a new metrics test.
CI against this dtest branch
[here|https://app.circleci.com/pipelines/github/aholmberg/cassandra?branch=CASSANDRA-16183].
One thing I noted while creating this test: While {{ViewWriteMetrics}} inherits
from {{ClientRequestMetrics}}, none of the [additional
members|https://github.com/aholmberg/cassandra/blob/93c2d763eb5107c2001384700be4b240ecf7a4b8/src/java/org/apache/cassandra/metrics/ClientRequestMetrics.java#L31-L33]
from that class are used. Would it be worth deprecating
{{ViewWriteMetrics.timeouts}}, etc and making that class derive directly from
{{LatencyMetrics}} in a later release, or should we just leave it?
> Add tests to cover ClientRequest metrics
> -----------------------------------------
>
> Key: CASSANDRA-16183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16183
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Benjamin Lerer
> Assignee: Adam Holmberg
> Priority: Normal
> Fix For: 4.0-beta
>
>
> We do not have test that covers the ClientRequest metrics.
> * ClientRequestMetrics
> * CASClientRequestMetrics
> * CASClientWriteRequestMetrics
> * ClientWriteRequestMetrics
> * ViewWriteMetrics
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
