[
https://issues.apache.org/jira/browse/CASSANDRA-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229352#comment-17229352
]
Adam Holmberg commented on CASSANDRA-16183:
-------------------------------------------
I understand what you're getting at. The reason I didn't do it in the first
place was twofold:
1.) It doesn't prove much other than [this map
lookup|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/StorageProxy.java#L776]
works with different values. The test is already asserting it works, and also
touching other metrics by asserting they're not changing.
2.) I originally didn't sweep other CLs because the basic test concept involves
making sure the right one changes, and others *don't* change. I was aware that
some metrics
[change/decay|https://github.com/aholmberg/cassandra/blob/c5eb532b63e80bb976d9dfdd4aa1c76f27f726e5/src/java/org/apache/cassandra/metrics/LatencyMetrics.java#L92]
over time and didn't want to introduce the complexity of worrying about racing
changes from previous iterations.
I've looked into it a bit more and I think the Count value we're asserting does
not decay, so maybe #2 will not be a problem.
Do you think it's worth sweeping CLs there?
> Add tests to cover ClientRequest metrics
> -----------------------------------------
>
> Key: CASSANDRA-16183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16183
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Benjamin Lerer
> Assignee: Adam Holmberg
> Priority: Normal
> Fix For: 4.0-beta
>
>
> We do not have test that covers the ClientRequest metrics.
> * ClientRequestMetrics
> * CASClientRequestMetrics
> * CASClientWriteRequestMetrics
> * ClientWriteRequestMetrics
> * ViewWriteMetrics
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
