leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final
Static Field
URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335598648
##########
File path:
processing/src/main/java/org/apache/druid/query/topn/PooledTopNAlgorithm.java
##########
@@ -50,17 +50,14 @@
/**
*/
+@SuppressWarnings("SSBasedInspection") // static field(s) cannot be final
because set in an static method
public class PooledTopNAlgorithm
extends BaseTopNAlgorithm<int[], BufferAggregator[],
PooledTopNAlgorithm.PooledTopNParams>
{
- private static boolean SPECIALIZE_GENERIC_ONE_AGG_POOLED_TOPN =
- !Boolean.getBoolean("dontSpecializeGeneric1AggPooledTopN");
- private static boolean SPECIALIZE_GENERIC_TWO_AGG_POOLED_TOPN =
- !Boolean.getBoolean("dontSpecializeGeneric2AggPooledTopN");
- private static boolean
SPECIALIZE_HISTORICAL_ONE_SIMPLE_DOUBLE_AGG_POOLED_TOPN =
-
!Boolean.getBoolean("dontSpecializeHistorical1SimpleDoubleAggPooledTopN");
- private static boolean
SPECIALIZE_HISTORICAL_SINGLE_VALUE_DIM_SELECTOR_ONE_SIMPLE_DOUBLE_AGG_POOLED_TOPN
=
-
!Boolean.getBoolean("dontSpecializeHistoricalSingleValueDimSelector1SimpleDoubleAggPooledTopN");
+ private static boolean SPECIALIZE_GENERIC_ONE_AGG_POOLED_TOPN =
!Boolean.getBoolean("dontSpecializeGeneric1AggPooledTopN");
Review comment:
Lines longer than 120 cols
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
