leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final
Static Field
URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335581582
##########
File path:
benchmarks/src/main/java/org/apache/druid/benchmark/query/ScanBenchmark.java
##########
@@ -102,6 +102,10 @@
@Measurement(iterations = 25)
public class ScanBenchmark
{
+ @Param({"NONE", "DESCENDING", "ASCENDING"})
+ @SuppressWarnings("SSBasedInspection") // static field(s) cannot be final
because set in an initializer block
+ private static ScanQuery.Order ordering;
Review comment:
This field is not set in an initializer block. Please check the truthfulness
of the comments that you add.
Since this is `@Param`, it shouldn't be static at all. Could you please
prohibit static `@Params` by adding another structured search pattern:
```java
@Param($Values$) static $T$ $param$;
```
in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
