leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final
Static Field
URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335596027
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/hyperloglog/HyperUniquesSerde.java
##########
@@ -38,8 +38,7 @@
public class HyperUniquesSerde extends ComplexMetricSerde
{
- private static Comparator<HyperLogLogCollector> comparator =
-
Comparator.nullsFirst(Comparator.comparing(HyperLogLogCollector::toByteBuffer));
+ private static final Comparator<HyperLogLogCollector> COMPARATOR =
Comparator.nullsFirst(Comparator.comparing(HyperLogLogCollector::toByteBuffer));
Review comment:
Line longer than 120 cols
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
