zml1206 commented on code in PR #9848:
URL: https://github.com/apache/incubator-gluten/pull/9848#discussion_r2123106281
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -40,83 +40,83 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
disableFallbackCheck
import testImplicits._
- test("Test abs function") {
+ test("abs") {
val df = runQueryAndCompare("SELECT abs(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test acos function") {
+ test("acos") {
runQueryAndCompare("SELECT acos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test asin function") {
+ test("asin") {
runQueryAndCompare("SELECT asin(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test atan function") {
+ test("atan") {
runQueryAndCompare("SELECT atan(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- ignore("Test atan2 function datatab") {
+ ignore("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test bin function") {
+ test("bin function") {
val df = runQueryAndCompare("SELECT bin(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceil function") {
+ test("ceil function") {
val df = runQueryAndCompare("SELECT ceil(cast(l_orderkey as long)) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceiling function") {
+ test("ceiling function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -40,83 +40,83 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
disableFallbackCheck
import testImplicits._
- test("Test abs function") {
+ test("abs") {
val df = runQueryAndCompare("SELECT abs(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test acos function") {
+ test("acos") {
runQueryAndCompare("SELECT acos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test asin function") {
+ test("asin") {
runQueryAndCompare("SELECT asin(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test atan function") {
+ test("atan") {
runQueryAndCompare("SELECT atan(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- ignore("Test atan2 function datatab") {
+ ignore("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test bin function") {
+ test("bin function") {
Review Comment:
please delete funciton
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -40,83 +40,83 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
disableFallbackCheck
import testImplicits._
- test("Test abs function") {
+ test("abs") {
val df = runQueryAndCompare("SELECT abs(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test acos function") {
+ test("acos") {
runQueryAndCompare("SELECT acos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test asin function") {
+ test("asin") {
runQueryAndCompare("SELECT asin(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test atan function") {
+ test("atan") {
runQueryAndCompare("SELECT atan(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- ignore("Test atan2 function datatab") {
+ ignore("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test bin function") {
+ test("bin function") {
val df = runQueryAndCompare("SELECT bin(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceil function") {
+ test("ceil function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -40,83 +40,83 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
disableFallbackCheck
import testImplicits._
- test("Test abs function") {
+ test("abs") {
val df = runQueryAndCompare("SELECT abs(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test acos function") {
+ test("acos") {
runQueryAndCompare("SELECT acos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test asin function") {
+ test("asin") {
runQueryAndCompare("SELECT asin(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test atan function") {
+ test("atan") {
runQueryAndCompare("SELECT atan(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- ignore("Test atan2 function datatab") {
+ ignore("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test bin function") {
+ test("bin function") {
val df = runQueryAndCompare("SELECT bin(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceil function") {
+ test("ceil function") {
val df = runQueryAndCompare("SELECT ceil(cast(l_orderkey as long)) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceiling function") {
+ test("ceiling function") {
runQueryAndCompare("SELECT ceiling(cast(l_orderkey as long)) from lineitem
limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test cos function") {
+ test("cos") {
runQueryAndCompare("SELECT cos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test cosh function") {
+ test("cosh") {
runQueryAndCompare("SELECT cosh(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test degrees function") {
+ test("degrees function") {
runQueryAndCompare("SELECT degrees(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test exp function") {
+ test("exp function") {
val df = runQueryAndCompare("SELECT exp(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test factorial function") {
+ test("factorial function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -217,47 +217,47 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test log function") {
+ test("log function") {
runQueryAndCompare("SELECT log(10, l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test log10 function") {
+ test("log10 function") {
runQueryAndCompare("SELECT log10(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test negative function") {
+ test("negative function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -187,13 +187,13 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test hex function") {
+ test("hex function") {
runQueryAndCompare("SELECT hex(l_partkey), hex(l_shipmode) FROM lineitem
limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test least function") {
+ test("least function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -269,7 +269,7 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test round function") {
+ test("round function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
runQueryAndCompare("SELECT shiftleft(int_field1, 1) from datatab limit 1")
{
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_add function") {
+ test("try_add function") {
runQueryAndCompare(
"select try_add(cast(l_orderkey as int), 1), try_add(cast(l_orderkey as
int), 2147483647)" +
" from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_divide function") {
+ test("try_divide function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -40,83 +40,83 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
disableFallbackCheck
import testImplicits._
- test("Test abs function") {
+ test("abs") {
val df = runQueryAndCompare("SELECT abs(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test acos function") {
+ test("acos") {
runQueryAndCompare("SELECT acos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test asin function") {
+ test("asin") {
runQueryAndCompare("SELECT asin(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test atan function") {
+ test("atan") {
runQueryAndCompare("SELECT atan(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- ignore("Test atan2 function datatab") {
+ ignore("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test bin function") {
+ test("bin function") {
val df = runQueryAndCompare("SELECT bin(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceil function") {
+ test("ceil function") {
val df = runQueryAndCompare("SELECT ceil(cast(l_orderkey as long)) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceiling function") {
+ test("ceiling function") {
runQueryAndCompare("SELECT ceiling(cast(l_orderkey as long)) from lineitem
limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test cos function") {
+ test("cos") {
runQueryAndCompare("SELECT cos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test cosh function") {
+ test("cosh") {
runQueryAndCompare("SELECT cosh(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test degrees function") {
+ test("degrees function") {
runQueryAndCompare("SELECT degrees(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test exp function") {
+ test("exp function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -350,7 +350,7 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test sqrt function") {
+ test("sqrt function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -732,7 +732,7 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("test array transform") {
+ test("transform function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -951,7 +951,7 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test input_file_name function") {
+ test("input_file_name function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -762,7 +762,7 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("test array exists") {
+ test("exists function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -524,37 +524,37 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
assert(e.getMessage.contains("l_orderkey"))
}
- test("Test E function") {
- runQueryAndCompare("""SELECT E() from lineitem limit 100""".stripMargin) {
+ test("EulerNumber") {
+ runQueryAndCompare("""SELECT E() from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
runQueryAndCompare("""SELECT E(), l_orderkey
- | from lineitem limit 100""".stripMargin) {
+ | from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test Pi function") {
- runQueryAndCompare("""SELECT Pi() from lineitem limit 100""".stripMargin) {
+ test("Pi") {
+ runQueryAndCompare("""SELECT Pi() from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
runQueryAndCompare("""SELECT Pi(), l_orderkey
- | from lineitem limit 100""".stripMargin) {
+ | from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test version function") {
- runQueryAndCompare("""SELECT version() from lineitem limit
100""".stripMargin) {
+ test("version function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -617,7 +617,7 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test uuid function") {
+ test("uuid function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -715,7 +715,7 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("test concat with array") {
+ test("concat function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -217,47 +217,47 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test log function") {
+ test("log function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -217,47 +217,47 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test log function") {
+ test("log function") {
runQueryAndCompare("SELECT log(10, l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test log10 function") {
+ test("log10 function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -156,14 +156,14 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test floor function") {
+ test("floor function") {
val df = runQueryAndCompare("SELECT floor(cast(l_orderkey as long)) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test greatest function") {
+ test("greatest function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -187,13 +187,13 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test hex function") {
+ test("hex function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -156,14 +156,14 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test floor function") {
+ test("floor function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -217,47 +217,47 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test log function") {
+ test("log function") {
runQueryAndCompare("SELECT log(10, l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test log10 function") {
+ test("log10 function") {
runQueryAndCompare("SELECT log10(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test negative function") {
+ test("negative function") {
runQueryAndCompare("select negative(l_orderkey) from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test pmod function") {
+ test("pmod") {
val df = runQueryAndCompare("SELECT pmod(cast(l_orderkey as int), 3) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test power function") {
+ test("power function") {
val df = runQueryAndCompare("SELECT power(l_orderkey, 2) from lineitem
limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test rand function") {
+ test("rand function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -40,83 +40,83 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
disableFallbackCheck
import testImplicits._
- test("Test abs function") {
+ test("abs") {
val df = runQueryAndCompare("SELECT abs(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test acos function") {
+ test("acos") {
runQueryAndCompare("SELECT acos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test asin function") {
+ test("asin") {
runQueryAndCompare("SELECT asin(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test atan function") {
+ test("atan") {
runQueryAndCompare("SELECT atan(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- ignore("Test atan2 function datatab") {
+ ignore("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test bin function") {
+ test("bin function") {
val df = runQueryAndCompare("SELECT bin(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceil function") {
+ test("ceil function") {
val df = runQueryAndCompare("SELECT ceil(cast(l_orderkey as long)) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceiling function") {
+ test("ceiling function") {
runQueryAndCompare("SELECT ceiling(cast(l_orderkey as long)) from lineitem
limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test cos function") {
+ test("cos") {
runQueryAndCompare("SELECT cos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test cosh function") {
+ test("cosh") {
runQueryAndCompare("SELECT cosh(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test degrees function") {
+ test("degrees function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
runQueryAndCompare("SELECT shiftleft(int_field1, 1) from datatab limit 1")
{
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_add function") {
+ test("try_add function") {
runQueryAndCompare(
"select try_add(cast(l_orderkey as int), 1), try_add(cast(l_orderkey as
int), 2147483647)" +
" from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_divide function") {
+ test("try_divide function") {
runQueryAndCompare(
"select try_divide(cast(l_orderkey as int), 0) from lineitem",
noFallBack = false) {
_ => // Spark would always cast inputs to double for this function.
}
}
- testWithMinSparkVersion("Test try_multiply function", "3.3") {
+ testWithMinSparkVersion("try_multiply function", "3.3") {
runQueryAndCompare(
"select try_multiply(2147483647, cast(l_orderkey as int)), " +
"try_multiply(-2147483648, cast(l_orderkey as int)) from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- testWithMinSparkVersion("Test try_subtract function", "3.3") {
+ testWithMinSparkVersion("try_subtract function", "3.3") {
runQueryAndCompare(
"select try_subtract(2147483647, cast(l_orderkey as int)), " +
"try_subtract(-2147483648, cast(l_orderkey as int)) from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test unhex function") {
+ test("unhex function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -217,47 +217,47 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test log function") {
+ test("log function") {
runQueryAndCompare("SELECT log(10, l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test log10 function") {
+ test("log10 function") {
runQueryAndCompare("SELECT log10(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test negative function") {
+ test("negative function") {
runQueryAndCompare("select negative(l_orderkey) from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test pmod function") {
+ test("pmod") {
val df = runQueryAndCompare("SELECT pmod(cast(l_orderkey as int), 3) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test power function") {
+ test("power function") {
val df = runQueryAndCompare("SELECT power(l_orderkey, 2) from lineitem
limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test rand function") {
+ test("rand function") {
runQueryAndCompare(
"""SELECT rand() from lineitem limit 100""".stripMargin,
compareResult = false) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test rint function") {
+ test("rint function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -217,47 +217,47 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test log function") {
+ test("log function") {
runQueryAndCompare("SELECT log(10, l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test log10 function") {
+ test("log10 function") {
runQueryAndCompare("SELECT log10(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test negative function") {
+ test("negative function") {
runQueryAndCompare("select negative(l_orderkey) from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test pmod function") {
+ test("pmod") {
val df = runQueryAndCompare("SELECT pmod(cast(l_orderkey as int), 3) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test power function") {
+ test("power function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
runQueryAndCompare("SELECT shiftleft(int_field1, 1) from datatab limit 1")
{
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_add function") {
+ test("try_add function") {
runQueryAndCompare(
"select try_add(cast(l_orderkey as int), 1), try_add(cast(l_orderkey as
int), 2147483647)" +
" from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_divide function") {
+ test("try_divide function") {
runQueryAndCompare(
"select try_divide(cast(l_orderkey as int), 0) from lineitem",
noFallBack = false) {
_ => // Spark would always cast inputs to double for this function.
}
}
- testWithMinSparkVersion("Test try_multiply function", "3.3") {
+ testWithMinSparkVersion("try_multiply function", "3.3") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
runQueryAndCompare("SELECT shiftleft(int_field1, 1) from datatab limit 1")
{
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_add function") {
+ test("try_add function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
runQueryAndCompare("SELECT shiftleft(int_field1, 1) from datatab limit 1")
{
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_add function") {
+ test("try_add function") {
runQueryAndCompare(
"select try_add(cast(l_orderkey as int), 1), try_add(cast(l_orderkey as
int), 2147483647)" +
" from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_divide function") {
+ test("try_divide function") {
runQueryAndCompare(
"select try_divide(cast(l_orderkey as int), 0) from lineitem",
noFallBack = false) {
_ => // Spark would always cast inputs to double for this function.
}
}
- testWithMinSparkVersion("Test try_multiply function", "3.3") {
+ testWithMinSparkVersion("try_multiply function", "3.3") {
runQueryAndCompare(
"select try_multiply(2147483647, cast(l_orderkey as int)), " +
"try_multiply(-2147483648, cast(l_orderkey as int)) from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- testWithMinSparkVersion("Test try_subtract function", "3.3") {
+ testWithMinSparkVersion("try_subtract function", "3.3") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -524,37 +524,37 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
assert(e.getMessage.contains("l_orderkey"))
}
- test("Test E function") {
- runQueryAndCompare("""SELECT E() from lineitem limit 100""".stripMargin) {
+ test("EulerNumber") {
+ runQueryAndCompare("""SELECT E() from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
runQueryAndCompare("""SELECT E(), l_orderkey
- | from lineitem limit 100""".stripMargin) {
+ | from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test Pi function") {
- runQueryAndCompare("""SELECT Pi() from lineitem limit 100""".stripMargin) {
+ test("Pi") {
+ runQueryAndCompare("""SELECT Pi() from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
runQueryAndCompare("""SELECT Pi(), l_orderkey
- | from lineitem limit 100""".stripMargin) {
+ | from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test version function") {
- runQueryAndCompare("""SELECT version() from lineitem limit
100""".stripMargin) {
+ test("version function") {
+ runQueryAndCompare("""SELECT version() from lineitem limit
10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
runQueryAndCompare("""SELECT version(), l_orderkey
- | from lineitem limit 100""".stripMargin) {
+ | from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test sum/count function") {
+ test("sum/count function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
runQueryAndCompare("SELECT shiftleft(int_field1, 1) from datatab limit 1")
{
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_add function") {
+ test("try_add function") {
runQueryAndCompare(
"select try_add(cast(l_orderkey as int), 1), try_add(cast(l_orderkey as
int), 2147483647)" +
" from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_divide function") {
+ test("try_divide function") {
runQueryAndCompare(
"select try_divide(cast(l_orderkey as int), 0) from lineitem",
noFallBack = false) {
_ => // Spark would always cast inputs to double for this function.
}
}
- testWithMinSparkVersion("Test try_multiply function", "3.3") {
+ testWithMinSparkVersion("try_multiply function", "3.3") {
runQueryAndCompare(
"select try_multiply(2147483647, cast(l_orderkey as int)), " +
"try_multiply(-2147483648, cast(l_orderkey as int)) from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- testWithMinSparkVersion("Test try_subtract function", "3.3") {
+ testWithMinSparkVersion("try_subtract function", "3.3") {
runQueryAndCompare(
"select try_subtract(2147483647, cast(l_orderkey as int)), " +
"try_subtract(-2147483648, cast(l_orderkey as int)) from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test unhex function") {
+ test("unhex function") {
runQueryAndCompare("SELECT unhex(hex(l_shipmode)) FROM lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- testWithMinSparkVersion("Test width_bucket function", "3.4") {
+ testWithMinSparkVersion("width_bucket function", "3.4") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -695,7 +695,7 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("test array filter") {
+ test("filter function") {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
