zml1206 commented on code in PR #9848:
URL: https://github.com/apache/incubator-gluten/pull/9848#discussion_r2123105600
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -40,83 +40,83 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
disableFallbackCheck
import testImplicits._
- test("Test abs function") {
+ test("abs") {
val df = runQueryAndCompare("SELECT abs(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test acos function") {
+ test("acos") {
runQueryAndCompare("SELECT acos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test asin function") {
+ test("asin") {
runQueryAndCompare("SELECT asin(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test atan function") {
+ test("atan") {
runQueryAndCompare("SELECT atan(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- ignore("Test atan2 function datatab") {
+ ignore("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test bin function") {
+ test("bin function") {
Review Comment:
please delete funciton
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -40,83 +40,83 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
disableFallbackCheck
import testImplicits._
- test("Test abs function") {
+ test("abs") {
val df = runQueryAndCompare("SELECT abs(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test acos function") {
+ test("acos") {
runQueryAndCompare("SELECT acos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test asin function") {
+ test("asin") {
runQueryAndCompare("SELECT asin(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test atan function") {
+ test("atan") {
runQueryAndCompare("SELECT atan(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- ignore("Test atan2 function datatab") {
+ ignore("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test bin function") {
+ test("bin function") {
val df = runQueryAndCompare("SELECT bin(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceil function") {
+ test("ceil function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -40,83 +40,83 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
disableFallbackCheck
import testImplicits._
- test("Test abs function") {
+ test("abs") {
val df = runQueryAndCompare("SELECT abs(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test acos function") {
+ test("acos") {
runQueryAndCompare("SELECT acos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test asin function") {
+ test("asin") {
runQueryAndCompare("SELECT asin(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test atan function") {
+ test("atan") {
runQueryAndCompare("SELECT atan(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- ignore("Test atan2 function datatab") {
+ ignore("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test bin function") {
+ test("bin function") {
val df = runQueryAndCompare("SELECT bin(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceil function") {
+ test("ceil function") {
val df = runQueryAndCompare("SELECT ceil(cast(l_orderkey as long)) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceiling function") {
+ test("ceiling function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -40,83 +40,83 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
disableFallbackCheck
import testImplicits._
- test("Test abs function") {
+ test("abs") {
val df = runQueryAndCompare("SELECT abs(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test acos function") {
+ test("acos") {
runQueryAndCompare("SELECT acos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test asin function") {
+ test("asin") {
runQueryAndCompare("SELECT asin(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test atan function") {
+ test("atan") {
runQueryAndCompare("SELECT atan(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- ignore("Test atan2 function datatab") {
+ ignore("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test bin function") {
+ test("bin function") {
val df = runQueryAndCompare("SELECT bin(l_orderkey) from lineitem limit
1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceil function") {
+ test("ceil function") {
val df = runQueryAndCompare("SELECT ceil(cast(l_orderkey as long)) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test ceiling function") {
+ test("ceiling function") {
runQueryAndCompare("SELECT ceiling(cast(l_orderkey as long)) from lineitem
limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test cos function") {
+ test("cos") {
runQueryAndCompare("SELECT cos(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test cosh function") {
+ test("cosh") {
runQueryAndCompare("SELECT cosh(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test degrees function") {
+ test("degrees function") {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
