zml1206 commented on code in PR #9848:
URL: https://github.com/apache/incubator-gluten/pull/9848#discussion_r2123112954
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
runQueryAndCompare("SELECT shiftleft(int_field1, 1) from datatab limit 1")
{
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_add function") {
+ test("try_add function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
runQueryAndCompare("SELECT shiftleft(int_field1, 1) from datatab limit 1")
{
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_add function") {
+ test("try_add function") {
runQueryAndCompare(
"select try_add(cast(l_orderkey as int), 1), try_add(cast(l_orderkey as
int), 2147483647)" +
" from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_divide function") {
+ test("try_divide function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
runQueryAndCompare("SELECT shiftleft(int_field1, 1) from datatab limit 1")
{
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_add function") {
+ test("try_add function") {
runQueryAndCompare(
"select try_add(cast(l_orderkey as int), 1), try_add(cast(l_orderkey as
int), 2147483647)" +
" from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test try_divide function") {
+ test("try_divide function") {
runQueryAndCompare(
"select try_divide(cast(l_orderkey as int), 0) from lineitem",
noFallBack = false) {
_ => // Spark would always cast inputs to double for this function.
}
}
- testWithMinSparkVersion("Test try_multiply function", "3.3") {
+ testWithMinSparkVersion("try_multiply function", "3.3") {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
