zml1206 commented on code in PR #9848:
URL: https://github.com/apache/incubator-gluten/pull/9848#discussion_r2123112250
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -217,47 +217,47 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test log function") {
+ test("log function") {
runQueryAndCompare("SELECT log(10, l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test log10 function") {
+ test("log10 function") {
runQueryAndCompare("SELECT log10(l_orderkey) from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test negative function") {
+ test("negative function") {
runQueryAndCompare("select negative(l_orderkey) from lineitem") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test pmod function") {
+ test("pmod") {
val df = runQueryAndCompare("SELECT pmod(cast(l_orderkey as int), 3) from
lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test power function") {
+ test("power function") {
val df = runQueryAndCompare("SELECT power(l_orderkey, 2) from lineitem
limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
checkLengthAndPlan(df, 1)
}
- test("Test rand function") {
+ test("rand function") {
runQueryAndCompare(
"""SELECT rand() from lineitem limit 100""".stripMargin,
compareResult = false) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test rint function") {
+ test("rint function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -269,7 +269,7 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test round function") {
+ test("round function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -288,51 +288,51 @@ abstract class MathFunctionsValidateSuite extends
FunctionsValidateSuite {
compareResultsAgainstVanillaSpark("select round(44, -1)", true, { _ => })
}
- test("Test shiftleft function") {
+ test("shiftleft function") {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
