zml1206 commented on code in PR #9848:
URL: https://github.com/apache/incubator-gluten/pull/9848#discussion_r2123126873
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -617,7 +617,7 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- test("Test uuid function") {
+ test("uuid function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -524,37 +524,37 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
assert(e.getMessage.contains("l_orderkey"))
}
- test("Test E function") {
- runQueryAndCompare("""SELECT E() from lineitem limit 100""".stripMargin) {
+ test("EulerNumber") {
+ runQueryAndCompare("""SELECT E() from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
runQueryAndCompare("""SELECT E(), l_orderkey
- | from lineitem limit 100""".stripMargin) {
+ | from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test Pi function") {
- runQueryAndCompare("""SELECT Pi() from lineitem limit 100""".stripMargin) {
+ test("Pi") {
+ runQueryAndCompare("""SELECT Pi() from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
runQueryAndCompare("""SELECT Pi(), l_orderkey
- | from lineitem limit 100""".stripMargin) {
+ | from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test version function") {
- runQueryAndCompare("""SELECT version() from lineitem limit
100""".stripMargin) {
+ test("version function") {
+ runQueryAndCompare("""SELECT version() from lineitem limit
10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
runQueryAndCompare("""SELECT version(), l_orderkey
- | from lineitem limit 100""".stripMargin) {
+ | from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test sum/count function") {
+ test("sum/count function") {
Review Comment:
ditto
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -524,37 +524,37 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
assert(e.getMessage.contains("l_orderkey"))
}
- test("Test E function") {
- runQueryAndCompare("""SELECT E() from lineitem limit 100""".stripMargin) {
+ test("EulerNumber") {
+ runQueryAndCompare("""SELECT E() from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
runQueryAndCompare("""SELECT E(), l_orderkey
- | from lineitem limit 100""".stripMargin) {
+ | from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test Pi function") {
- runQueryAndCompare("""SELECT Pi() from lineitem limit 100""".stripMargin) {
+ test("Pi") {
+ runQueryAndCompare("""SELECT Pi() from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
runQueryAndCompare("""SELECT Pi(), l_orderkey
- | from lineitem limit 100""".stripMargin) {
+ | from lineitem limit 10""".stripMargin) {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
}
- test("Test version function") {
- runQueryAndCompare("""SELECT version() from lineitem limit
100""".stripMargin) {
+ test("version function") {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
