philo-he commented on code in PR #12036:
URL: https://github.com/apache/gluten/pull/12036#discussion_r3257154860
##########
gluten-substrait/src/test/scala/org/apache/gluten/config/AllGlutenConfiguration.scala:
##########
@@ -147,6 +166,16 @@ class AllGlutenConfiguration extends AnyFunSuite {
}
object AllGlutenConfiguration {
+ private val Anchor = Character.toString(0x2693)
+ private val CounterclockwiseArrows = new String(Character.toChars(0x1f504))
+
+ val staticConfigStatus: String = s"$Anchor Static"
+ val dynamicConfigStatus: String = s"$CounterclockwiseArrows Dynamic"
+
+ def configStatus(entry: ConfigEntry[_]): String = {
Review Comment:
Perhaps, `def configModifiability(key: String)` is better.
##########
gluten-substrait/src/test/scala/org/apache/gluten/config/AllGlutenConfiguration.scala:
##########
@@ -67,44 +69,53 @@ class AllGlutenConfiguration extends AnyFunSuite {
s"""
|## Spark base configurations for Gluten plugin
|
- | Key | Recommend Setting | Description
- | --- | --- | ---
+ | Key | Status | Recommend Setting | Description
+ | --- | --- | --- | ---
|"""
// scalastyle:off
builder += Seq(
"spark.plugins",
+ AllGlutenConfiguration.staticConfigStatus,
"org.apache.gluten.GlutenPlugin",
"To load Gluten's components by Spark's plug-in loader.").mkString("|")
builder += Seq(
"spark.memory.offHeap.enabled",
+ AllGlutenConfiguration.staticConfigStatus,
"true",
"Gluten use off-heap memory for certain operations.").mkString("|")
builder += Seq(
"spark.memory.offHeap.size",
+ AllGlutenConfiguration.staticConfigStatus,
"30G",
"The absolute amount of memory which can be used for off-heap
allocation, in bytes unless otherwise specified.<br /> Note: Gluten Plugin will
leverage this setting to allocate memory space for native usage even offHeap is
disabled. <br /> The value is based on your system and it is recommended to set
it larger if you are facing Out of Memory issue in Gluten Plugin."
).mkString("|")
builder += Seq(
"spark.shuffle.manager",
+ AllGlutenConfiguration.staticConfigStatus,
Review Comment:
Can we use `configStatus("spark.shuffle.manager")? I assume
`SQLConf.isStaticConfigKey(key)` can do the correct check. Ditto for the above
similar configurations.
##########
gluten-substrait/src/test/scala/org/apache/gluten/config/AllGlutenConfiguration.scala:
##########
@@ -67,44 +69,53 @@ class AllGlutenConfiguration extends AnyFunSuite {
s"""
|## Spark base configurations for Gluten plugin
|
- | Key | Recommend Setting | Description
- | --- | --- | ---
+ | Key | Status | Recommend Setting | Description
Review Comment:
Seems "Modifiability" is better than "Status"? The latter sounds a bit
general.
##########
backends-velox/src/test/scala/org/apache/gluten/config/AllVeloxConfiguration.scala:
##########
@@ -42,8 +42,8 @@ class AllVeloxConfiguration extends AnyFunSuite {
s"""
|## Gluten Velox backend configurations
|
- | Key | Default | Description
- | --- | --- | ---
+ | Key | Status | Default | Description
Review Comment:
Ditto.
##########
gluten-substrait/src/test/scala/org/apache/gluten/config/AllGlutenConfiguration.scala:
##########
@@ -147,6 +166,16 @@ class AllGlutenConfiguration extends AnyFunSuite {
}
object AllGlutenConfiguration {
+ private val Anchor = Character.toString(0x2693)
+ private val CounterclockwiseArrows = new String(Character.toChars(0x1f504))
+
+ val staticConfigStatus: String = s"$Anchor Static"
+ val dynamicConfigStatus: String = s"$CounterclockwiseArrows Dynamic"
Review Comment:
Name suggestion: "dynamicConfigLabel".
##########
gluten-substrait/src/test/scala/org/apache/gluten/config/AllGlutenConfiguration.scala:
##########
@@ -147,6 +166,16 @@ class AllGlutenConfiguration extends AnyFunSuite {
}
object AllGlutenConfiguration {
+ private val Anchor = Character.toString(0x2693)
+ private val CounterclockwiseArrows = new String(Character.toChars(0x1f504))
+
+ val staticConfigStatus: String = s"$Anchor Static"
Review Comment:
Name suggestion: "staticConfigLabel".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
