malinjawi commented on code in PR #12036:
URL: https://github.com/apache/gluten/pull/12036#discussion_r3265309485
##########
gluten-substrait/src/test/scala/org/apache/gluten/config/AllGlutenConfiguration.scala:
##########
@@ -67,44 +69,53 @@ class AllGlutenConfiguration extends AnyFunSuite {
s"""
|## Spark base configurations for Gluten plugin
|
- | Key | Recommend Setting | Description
- | --- | --- | ---
+ | Key | Status | Recommend Setting | Description
+ | --- | --- | --- | ---
|"""
// scalastyle:off
builder += Seq(
"spark.plugins",
+ AllGlutenConfiguration.staticConfigStatus,
"org.apache.gluten.GlutenPlugin",
"To load Gluten's components by Spark's plug-in loader.").mkString("|")
builder += Seq(
"spark.memory.offHeap.enabled",
+ AllGlutenConfiguration.staticConfigStatus,
"true",
"Gluten use off-heap memory for certain operations.").mkString("|")
builder += Seq(
"spark.memory.offHeap.size",
+ AllGlutenConfiguration.staticConfigStatus,
"30G",
"The absolute amount of memory which can be used for off-heap
allocation, in bytes unless otherwise specified.<br /> Note: Gluten Plugin will
leverage this setting to allocate memory space for native usage even offHeap is
disabled. <br /> The value is based on your system and it is recommended to set
it larger if you are facing Out of Memory issue in Gluten Plugin."
).mkString("|")
builder += Seq(
"spark.shuffle.manager",
+ AllGlutenConfiguration.staticConfigStatus,
Review Comment:
Done. The Spark base config rows now use configModifiability(key), including
spark.shuffle.manager and the related Spark configs.
##########
gluten-substrait/src/test/scala/org/apache/gluten/config/AllGlutenConfiguration.scala:
##########
@@ -147,6 +166,16 @@ class AllGlutenConfiguration extends AnyFunSuite {
}
object AllGlutenConfiguration {
+ private val Anchor = Character.toString(0x2693)
+ private val CounterclockwiseArrows = new String(Character.toChars(0x1f504))
+
+ val staticConfigStatus: String = s"$Anchor Static"
+ val dynamicConfigStatus: String = s"$CounterclockwiseArrows Dynamic"
+
+ def configStatus(entry: ConfigEntry[_]): String = {
Review Comment:
Done. Renamed the helper to configModifiability(key: String).
##########
gluten-substrait/src/test/scala/org/apache/gluten/config/AllGlutenConfiguration.scala:
##########
@@ -147,6 +166,16 @@ class AllGlutenConfiguration extends AnyFunSuite {
}
object AllGlutenConfiguration {
+ private val Anchor = Character.toString(0x2693)
+ private val CounterclockwiseArrows = new String(Character.toChars(0x1f504))
+
+ val staticConfigStatus: String = s"$Anchor Static"
Review Comment:
Done. Renamed staticConfigStatus to staticConfigLabel.
##########
gluten-substrait/src/test/scala/org/apache/gluten/config/AllGlutenConfiguration.scala:
##########
@@ -147,6 +166,16 @@ class AllGlutenConfiguration extends AnyFunSuite {
}
object AllGlutenConfiguration {
+ private val Anchor = Character.toString(0x2693)
+ private val CounterclockwiseArrows = new String(Character.toChars(0x1f504))
+
+ val staticConfigStatus: String = s"$Anchor Static"
+ val dynamicConfigStatus: String = s"$CounterclockwiseArrows Dynamic"
Review Comment:
Done. Renamed dynamicConfigStatus to dynamicConfigLabel.
##########
gluten-substrait/src/test/scala/org/apache/gluten/config/AllGlutenConfiguration.scala:
##########
@@ -67,44 +69,53 @@ class AllGlutenConfiguration extends AnyFunSuite {
s"""
|## Spark base configurations for Gluten plugin
|
- | Key | Recommend Setting | Description
- | --- | --- | ---
+ | Key | Status | Recommend Setting | Description
Review Comment:
Done. Updated the generated Configuration.md column to Modifiability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
