malinjawi commented on code in PR #12821:
URL: https://github.com/apache/gluten/pull/12821#discussion_r3849994551
##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -596,6 +596,7 @@ core::PlanNodePtr
SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
if (substraitAggMask.ByteSizeLong() > 0) {
mask = std::dynamic_pointer_cast<const core::FieldAccessTypedExpr>(
exprConverter_->toVeloxExpr(substraitAggMask, inputType));
+ VELOX_USER_CHECK_NOT_NULL(mask, "Aggregation Operator only supports a
top-level field mask.");
Review Comment:
Not in the normal Spark SQL native plan. PullOutPreProject converts a nested
filter into a top-level field first. This check is defensive for direct
Substrait plans and prevents the filter from being silently dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
