malinjawi commented on code in PR #12821:
URL: https://github.com/apache/gluten/pull/12821#discussion_r3850013927
##########
cpp/velox/substrait/SubstraitToVeloxExpr.cc:
##########
@@ -651,7 +700,7 @@ core::TypedExprPtr SubstraitVeloxExprConverter::toVeloxExpr(
case ::substrait::Expression::RexTypeCase::kScalarFunction:
return toVeloxExpr(substraitExpr.scalar_function(), inputType);
case ::substrait::Expression::RexTypeCase::kSelection:
- return toVeloxExpr(substraitExpr.selection(), inputType);
+ return toVeloxOrdinalFieldReferenceExpr(substraitExpr.selection(),
inputType);
Review Comment:
Checked end to end. These Velox operators only accept top-level channels and
never evaluated the old nested FieldAccess chain correctly. Gluten already
preprojects nested sort, window, and generate expressions into top-level
fields. Top-level behavior is unchanged; ordinal Dereference is used only where
nested expressions can actually be evaluated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
