malinjawi commented on PR #12821: URL: https://github.com/apache/gluten/pull/12821#issuecomment-5438325907
> @malinjawi does this fixes Delta column mapping? I noticed several tests are now passing, I suspect because of this change Yes @felipepessoto it looks like this fixed a subset of Delta column-mapping cases. The change is generic rather than Delta-specific: nested Substrait references now preserve their ordinals instead of resolving children by name. That also handles renamed or reordered nested Delta fields correctly. The nightly run confirmed 32 previously failing tests now pass. I wouldn’t describe it as fixing all Delta column mapping, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
