malinjawi commented on code in PR #12821:
URL: https://github.com/apache/gluten/pull/12821#discussion_r3850018594
##########
cpp/velox/substrait/SubstraitToVeloxExpr.cc:
##########
@@ -651,7 +700,7 @@ core::TypedExprPtr SubstraitVeloxExprConverter::toVeloxExpr(
case ::substrait::Expression::RexTypeCase::kScalarFunction:
return toVeloxExpr(substraitExpr.scalar_function(), inputType);
case ::substrait::Expression::RexTypeCase::kSelection:
- return toVeloxExpr(substraitExpr.selection(), inputType);
+ return toVeloxOrdinalFieldReferenceExpr(substraitExpr.selection(),
inputType);
Review Comment:
@zhouyuan Confirmed and fixed in d51133e38. Expand now passes the full
projectExpr, while both validation and conversion require a top-level field
because Velox Expand cannot execute nested dereferences. Nested selections now
fall back cleanly, with tests for both paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
