malinjawi commented on code in PR #12821:
URL: https://github.com/apache/gluten/pull/12821#discussion_r3850023573
##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -596,6 +596,7 @@ core::PlanNodePtr
SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
if (substraitAggMask.ByteSizeLong() > 0) {
mask = std::dynamic_pointer_cast<const core::FieldAccessTypedExpr>(
exprConverter_->toVeloxExpr(substraitAggMask, inputType));
+ VELOX_USER_CHECK_NOT_NULL(mask, "Aggregation Operator only supports a
top-level field mask.");
Review Comment:
Validation and conversion now use the same top-level-field check, so nested
masks fall back during validation. The runtime guard remains, and PlanValidator
coverage was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
