hudi-agent commented on code in PR #19217:
URL: https://github.com/apache/hudi/pull/19217#discussion_r3717044987
##########
hudi-integ-test/src/test/java/org/apache/hudi/integ2/testcontainers/TestcontainersConfig.java:
##########
@@ -43,6 +43,7 @@ public static final class Containers {
public static final String SPARK_MASTER = "sparkmaster";
// Testcontainers appends the replica index, so the adhoc services resolve
as "<name>-1".
public static final String ADHOC_1 = "adhoc-1-1";
+ public static final String TRINOCOORDINATOR = "trinocoordinator";
Review Comment:
🤖 nit: for consistency with the neighboring constants (SPARK_MASTER,
ADHOC_1), could you name this TRINO_COORDINATOR = "trinocoordinator"? The value
must stay unbroken to match the compose service, but the identifier reads oddly
without the underscore.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
