voonhous commented on code in PR #19217: URL: https://github.com/apache/hudi/pull/19217#discussion_r3718322368
########## .github/workflows/hudi_trino_e2e.yml: ########## @@ -0,0 +1,177 @@ +name: Hudi Trino E2E + +on: + push: + branches: + - master + - 'release-*' + paths: + # docker/demo/** is deliberately broad: the ITs drive several demo fixture + # scripts (sparksql-*.commands, setup_demo_container.sh), so any demo edit + # must re-run this pipeline. + - 'hudi-trino/**' + - 'docker/trino/**' + - 'docker/compose/docker-compose_hadoop340_hive2310_spark402*' + # hadoop.env is copied into the generated compose dir and loaded by every + # service in the stack, so it is as load-bearing as the YAMLs themselves. + - 'docker/compose/hadoop.env' + - 'docker/demo/**' + - 'hudi-integ-test/src/test/java/org/apache/hudi/integ2/**' Review Comment: Both confirmed, took both. - `pom.xml:134` owns `<trino.version>481</trino.version>`, and it is tracked by hand in five places: the shim pom parent coordinate (whose comment already says "must stay in sync with trino.version in the root pom"), `Dockerfile` `ARG TRINO_VERSION=481`, `build_image.sh`'s default, and four hardcoded `trino-hudi-481` / `hudi-trino_481` paths in this workflow. Added `pom.xml`, same as `hudi_trino_ci.yml`. - Right about the module scope -- `mvn verify -pl hudi-integ-test` compiles the whole module, and this PR's own `integ/ITTestBase` and `integ/ITTestHoodieDemo` edits sit outside `integ2/`. Widened to `hudi-integ-test/**`. Also folded the per-entry comments into one rationale block above the `push` list, with `pull_request` pointing at it, so the two lists stay easy to diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
