wombatu-kun commented on code in PR #19217: URL: https://github.com/apache/hudi/pull/19217#discussion_r3718227535
########## .github/workflows/hudi_trino_e2e.yml: ########## @@ -0,0 +1,177 @@ +name: Hudi Trino E2E + +on: + push: + branches: + - master + - 'release-*' + paths: + # docker/demo/** is deliberately broad: the ITs drive several demo fixture + # scripts (sparksql-*.commands, setup_demo_container.sh), so any demo edit + # must re-run this pipeline. + - 'hudi-trino/**' + - 'docker/trino/**' + - 'docker/compose/docker-compose_hadoop340_hive2310_spark402*' + # hadoop.env is copied into the generated compose dir and loaded by every + # service in the stack, so it is as load-bearing as the YAMLs themselves. + - 'docker/compose/hadoop.env' + - 'docker/demo/**' + - 'hudi-integ-test/src/test/java/org/apache/hudi/integ2/**' Review Comment: These lists miss root `pom.xml`, which owns the `trino.version` that the shim pom, the `TRINO_VERSION` build arg and the hardcoded `481` steps below all have to track, and they narrow the test entry to `integ2/**` while the IT step runs `mvn verify -pl hudi-integ-test` over the whole module - this PR's own edits to `ITTestBase` and `ITTestHoodieDemo` sit outside it. Add `pom.xml` and widen to `hudi-integ-test/**`, the way `hudi_trino_ci.yml` does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
