voonhous commented on code in PR #19217: URL: https://github.com/apache/hudi/pull/19217#discussion_r3718083747
########## docker/trino/etc/catalog/hudi.properties: ########## @@ -0,0 +1,30 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# Native trino-hudi connector (assembled from org.apache.hudi:hudi-trino by the +# docker/trino/shim project). +# Pre-Trino 472 the only way to read Hudi was the hive-connector + hudi-trino-bundle shim; Review Comment: Confirmed and fixed -- `plugin/trino-hudi` resolves at tag `398` and 404s at `397`, so 472 was wrong. Kept the historical clause with the corrected number rather than dropping it, since it is what explains why this is `connector.name=hudi` and not the old bundle-on-hive-connector setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
