[GitHub] [hudi] n3nash commented on a change in pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

[GitBox]

n3nash commented on a change in pull request #2923:
URL: https://github.com/apache/hudi/pull/2923#discussion_r642692200



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java
##########
@@ -62,7 +62,7 @@
         } else if (kvArray[1].equals(EMPTY_RECORDKEY_PLACEHOLDER)) {
           return "";
         } else {
-          return kvArray[1];
+          return String.join(":", Arrays.copyOfRange(kvArray, 1, 
kvArray.length));

Review comment:
       Seems like a correct fix. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org