tomatotomata commented on PR #11602: URL: https://github.com/apache/seatunnel/pull/11602#issuecomment-5271528089
I folded the remaining parsing nit into `f127a13e0`. The new `metrics-fetch-timeout-ms` branch now uses Hazelcast's `getLongValue(...)`, so invalid values get the same parameter-named configuration error as the sibling numeric options. `git diff --check` passes. I also reran the focused Maven compile, but this checkout cannot resolve the repository's unpublished `seatunnel-shade:3.0.0-SNAPSHOT` dependency from the snapshot repository, so CI is still the place to confirm the module build. The earlier config and test fixes remain in the pushed history. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
